Skip to content

Sync to upstream #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 62 commits into from
Nov 19, 2019
Merged

Sync to upstream #2

merged 62 commits into from
Nov 19, 2019

Conversation

zztalker
Copy link
Owner

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

IanMatthewHuff and others added 30 commits November 5, 2019 18:38
* Update typescript to 3.7

* Fix compiler issues
* Ensure we only have one gather logger per nb.

* Fix localiize string fallback
* Moved the un above and below buttons from
the cell toolbar to the main one.

The cell Toolbar is now on top of the cell.

* Fixed some styles and removed some comments

* Added news entry

* fixed some tests

* more test fixes

* test fixes

* make the toolbar not render on outputs

* changed the logic to decide if we render the
toolbar or not to renderOutput()

* remove run button from markdown cells
* Add support for vegas

* Add news entry

* Update dependencies
* Cache conda information
* Add tests
* Fix tests and address code review comments
* Remove try...catch

* Correct type

* Fix CI

* Remove comment
* Attempt to cache node_modules

* Change npm ci to install so we can actually cache

* Follow directions on devops docs

* Move variable and fix spacing

* Use restore cache

* Put back dependencies
This change is purely UI, and does not affect tests.
* Updated versions for extension and LS
* Update package-lock.json
* Update Changelog
* Update TPN
* Update master branch extension version

* Fix package-lock.json
* Skip checking dependencies in PRs
* News
* Activate using path when name is not available

* Add news item

* Some cleanup
* Fixes to Jupyter daemon and refactor jupyter commands
* Fix compiler issues
* Fix linter
* Fixes to tests
#8482)

* Fix cells being erased when saving and then changing focus to another cell

* Make sure to use the source even if it's empty
karthiknadig and others added 28 commits November 12, 2019 12:30
…el (#8461)

* Ensure wheels control group uses no wheel ptvsd
* Improve condition readability in jupyter debugger
* Skip Python 2.7 in Daemon tests
* Increase test timeout
* Creating a process is slow on windows
* Rename debug adapter experiment group

* Adjust experiment numbers to 20% in debug adapter experiment and 7% in wheels experiment

* Revert "Adjust experiment numbers to 20% in debug adapter experiment and 7% in wheels experiment"

This reverts commit ee8db47.

* Shutting off experiments pre-release
* Add ability to ignore bootstrap code from tests
* Add debug config
…ear all output' (#8536)

* Clear execution count and output in the file
when the user clicks 'clear all output'

* Added news file

* used immutable to change the cells

* removed some verifies from the functional test

* added logs to debug azure pipeline

* Removed immutable form the extension side.
Made sure to not delete 'execution_count' on the front.
Tests will be added back in another PR.
* Add ptvsd_attach support

* Add news item

* Fix tests

* Address comments
* Fixes to Jupyter daemon and refactor jupyter commands
* Prompt selecting a file to save once
* Better algorithm
)

* Creating a new blank notebook should not require a search for jupyter.

* Fix bug caused by other fix.
* First ideas

* Wire up post office

* Execution

* Variable explorer

* Add mapping for messages from the webview

* Rework redux to be type safe for mapped functions

* Move reducer to new file
Make support of second arg optional

* Add in some of the window messages

* Bunch more messages. Refactor sending to the post office to not be part of state

* Add a bunch more actions

* Get nativeEditor and nativeCell clean by finishing all actions

* Finishing off more messages

* Update to split state, 1 for monaco, 1 for react

* Eliminate nativeEditorStateController all together

* Partial idea for common reducers

* All interactiveWindow actions wired up

* Refactor to dispatch messages instead using custom post function

* Get the interactive cell building

* All regular source building

* All compiler errors fixed

* Fix webpack build errors

* Basic UI showing up

* Focus and moving between cells

* Fix changing cell type to focus

* Fix execution to actually use the code

* Fixup after merge with master

* Fix start message and click for edit box

* Add back the two other start messages

* Refactor to have payload in actions instead of just plain object

* Fix collapse button on interactive window

* Fix tokenizer to work again

* Fix intellisense to work by reworking how it handles messages

* Fix merge and error caused by gatherListener

* Get unit tests to run

* Fix proc unit tests to pass on windows

* Actually fix killing a process

* Fix unit tests after change to test data

* Send the same messages for tests that we used to

* Get intellisense tests working again by removing state on unmount

* Fixup state to match what we used to have when testing
Fix settings to update during tests

* Fix undo/redo

* Add support for updateContexts

* Get all keyboard tests passing
Fix undo to keep track of selection
Fix execution to change selection at the same time

* Fix save tests

* Put back code to wait for an update

* Add news entry

* Remove unused packages

* Fix message conflicts

* Fix run cell to disappear on markdown

* Don't execute markdown cells

* Fix arrow up/arrow down to save code

* Fix disposed intellisense provider still dispatching

* Fix intellisenseProvider to not dispatch. Have it use post office directly

* Fix scrolling and variable explorer
Fix variable explorer tests
Turn off logger when in production mode

* Put back launch.json

* Review comments

* Fixup after merge

* Put back delete button on markdown

* Fix redo
* Add logging

* Fix test

* Better logging

* Daemons weren't disposed when closing VS Code

* Dispose daemons properly

* Fix tests

* Restore counts

* Use linux VM
* Support the ability to take input

* Add support for silent commands too
* Update jupyterlab/services for ipywidgets

* Fix compiler issues after updating npm package

* More ignores
* Initial commit
* Ignore ipywidgets folder
* Slight modifications and added our aliases

* Update Feature request template

* Shorten title.

* Update 1_ds_bug_report.md

* Update 3_ds_feature_request.md

* Update 1_ds_bug_report.md

* Update 3_ds_feature_request.md
* Rename debug adapter experiment group

* Adjust experiment numbers to 20% in debug adapter experiment and 7% in wheels experiment

* Revert "Adjust experiment numbers to 20% in debug adapter experiment and 7% in wheels experiment"

This reverts commit ee8db47.

* Shutting off experiments pre-release

* Turn on DebugAdapter and wheels experiments for 20% and 7% of users, respectively
* added tests

* added check for execution count on the html

* Added test to check if .ipynb file is changed

* changed a waitForUpdate to a sleep, to try and
pass the test on linux

* Removed a test that breaks the Azure Pipeline.

* fixed a warning
* Support saving plotly graphs in the Interactive Window or inside of a notebook.

* Fix sonar warnings
@zztalker zztalker merged commit 147ff15 into zztalker:master Nov 19, 2019
zztalker pushed a commit that referenced this pull request May 13, 2020
* Update branch name (for testing)

* TypeScript tests

* python unit tests

* ipython unit tests

* single, multi, debugger tests

* functional tests

* Comment out VSIX build+upload when testing the action

* Cache out/ directory

* rename step id to more specific pythonFiles

* single workspace tests

* multi workspace tests

* debugger tests

* Add todo for when the PR is ready for review

* Fix out/ cache key

* Fix pythonFiles cache key

* Retry single workspace tests

* Use same cache key everywhere

* Try out multi workspace tests

* Try out debugger tests

* Uncomment compile + upload step

* run venv tests

* Update branch name to trigger workflow

* Adding comments + enable full test suite

* Finalize versions of python we want to use

* Try 3.7 instead of 3.8

* Run the workflow only on upstream master

* Clean up comments

* Revert to 3.8

* Update .github/workflows/ci.yml

Co-Authored-By: Brett Cannon <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Brett Cannon <[email protected]>

* Rename test suite matrix key

* Try bang operator

* Make python cache keys more specific

* Move repo condition up

* Run a subset of tests to see if stuff still works

* Update the branch to test the workflow

* Try leaving no space between ! and the expression

* Undo ! testing

* Update pythonFiles cache key

* Smoke tests

* Don't install vsce globally

* Where my env var value at

* well this one didn't work

* Use correct env var syntax

* Remove curly brackets

* Use xvfb for smoke tests

* Take prep work outside of xvfb step

* Uncomment things

* Comment things out for testing

* Merge master, fix things

* forgot to comment condition

* Uncomment testing checks

* Newlines

* Whitespaces #2

* Run tests on windows

* Remember to package the Python files

* Update build number earlier

* Use existing VSIX artifact instead of repackaging

* Skip repo condition for a test run

* List directory content (debug)

* Update ci.yml

* Update ci.yml

* Undo download artifact changes to compare

* Re-add brackets

* Force update build nb on bash shell

* Do not call gulp:cleanExceptTests 😒

* Download artifact in place

* Only run npx tsc -p ./

* Comment windows for now, re-run all prep (comparison)

* Correct path for artifact download

* Extract vsix from download location

* Remove path when downloading

* Cleanup now that the smoke tests run

* Remove repo conditions (ready to be merged)

* Newline

* Don't need the python files in smoke tests

* Ready for re-review

* npm ci --prefer-offline

Co-authored-by: Brett Cannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.