Skip to content

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Nov 15, 2019

For #3429

This is required for ipywdigets (use latest version of jupyter services).
No news entry file for this, will add a single one when ipywidgets lands, don't see a point of adding news entry for updating npm packages

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Nov 15, 2019
@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #8607 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8607      +/-   ##
==========================================
- Coverage   59.11%   59.11%   -0.01%     
==========================================
  Files         520      520              
  Lines       23936    23938       +2     
  Branches     3869     3870       +1     
==========================================
  Hits        14150    14150              
- Misses       8867     8869       +2     
  Partials      919      919
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø) ⬆️
src/client/datascience/jupyter/jupyterNotebook.ts 6.13% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab4d796...3fd5fc1. Read the comment docs.

@rchiodo rchiodo merged commit 806005d into microsoft:master Nov 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
@DonJayamanne DonJayamanne deleted the updateNpmPackages branch December 17, 2019 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants