Skip to content

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Nov 1, 2019

For #8105

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Unit tests & system/integration tests are added/updated

@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #8340 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8340      +/-   ##
==========================================
+ Coverage   59.39%   59.41%   +0.01%     
==========================================
  Files         509      509              
  Lines       23422    23431       +9     
  Branches     3786     3790       +4     
==========================================
+ Hits        13912    13921       +9     
  Misses       8604     8604              
  Partials      906      906
Impacted Files Coverage Δ
src/client/debugger/extension/hooks/types.ts 100% <ø> (ø) ⬆️
src/client/debugger/types.ts 100% <ø> (ø) ⬆️
src/client/debugger/extension/hooks/constants.ts 100% <100%> (ø) ⬆️
...ugger/extension/hooks/childProcessAttachHandler.ts 100% <100%> (ø) ⬆️
...ugger/extension/hooks/childProcessAttachService.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9862c6a...721a958. Read the comment docs.

@karthiknadig karthiknadig marked this pull request as ready for review November 4, 2019 21:21
@karthiknadig karthiknadig merged commit f71b070 into microsoft:master Nov 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 21, 2019
@karthiknadig karthiknadig deleted the 8105 branch December 27, 2019 02:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants