Merge pull request #2 from microsoft/master

Sync to upstream

Author: zztalker

.github/ISSUE_TEMPLATE/1_ds_bug_report.md

@@ -3,7 +3,7 @@ name: Bug report for Notebook Editor, Interactive Window, Python Editor cells
 about: Create a report to help us improve
 labels: type-bug, data science
 ---
-# Bug: Notebook Editor, Interactive Window, Python Editor cells
+# Bug: Notebook Editor, Interactive Window, Editor cells
 
 <!-----------------------------------------------------------------------------------------------
                                                       ***PLEASE READ***
@@ -15,7 +15,9 @@ bug template instead of this one. ***Thank you!***
 ## Steps to cause the bug to occur
 1.
 
-## Actual & Expected behavior
+## Actual behavior
+
+## Expected behavior
 
 <!-----------------------------------------------------------------------------------------------
 Animated GIFs can be effective means to describe a bug. Consider using a tool like
@@ -38,7 +40,7 @@ Copy/paste the output in the "Console" tab in the "Developer Tools" panel (Help
 Toggle Developer Tools). For better details, run the "Enable source map support for
 extension debugging" command in VS Code at least once beforehand.
 ------------------------------------------------------------------------------------------------->
-
+Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer
 
 
 

.github/ISSUE_TEMPLATE/2_bug_report.md

@@ -25,6 +25,8 @@ XXX
 XXX
 
 ## Steps to reproduce:
+[**NOTE**: Self-contained, minimal reproducing code samples are **extremely** helpful and will expedite addressing your issue]
+
 1. XXX
 
 <!--

.github/ISSUE_TEMPLATE/3_ds_feature_request.md

@@ -1,5 +1,5 @@
 ---
-name: Feature request for Notebook Editor, Interactive Window, Python Editor cells
+name: Feature request for Notebook Editor, Interactive Window, Editor cells
 about: Suggest an idea for this project
 labels: type-enhancement, data science
 ---
@@ -15,4 +15,6 @@ request template instead of this one. ***Thank you!***
 ## Description
 
 
+Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer
+
 

.vscode/launch.json

@@ -158,6 +158,29 @@
             "preLaunchTask": "Compile",
             "skipFiles": ["<node_internals>/**"]
         },
+        {
+            "name": "Unit Tests (fast, without VS Code and without react/monaco, *.unit.test.ts)",
+            "type": "node",
+            "request": "launch",
+            "program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
+            "stopOnEntry": false,
+            "sourceMaps": true,
+            "args": [
+                "./out/test/**/*.unit.test.js",
+                "--require=out/test/unittests.js",
+                "--ui=tdd",
+                "--recursive",
+                "--colors",
+                //"--grep", "<suite name>",
+                "--timeout=300000",
+                "--fast"
+            ],
+            "outFiles": [
+                "${workspaceFolder}/out/**/*.js"
+            ],
+            "preLaunchTask": "Compile",
+            "skipFiles": ["<node_internals>/**"]
+        },
         {
             "name": "Functional Tests (without VS Code, *.functional.test.ts)",
             "type": "node",

CHANGELOG.md

@@ -1,5 +1,200 @@
 # Changelog
 
+## 2019.11.0-rc (7 November 2019)
+
+### Enhancements
+
+1. Add Vega support into our list of transforms for output.
+   ([#4125](https://github.com/Microsoft/vscode-python/issues/4125))
+1. Add `.flake8` file association as ini-file.
+   (thanks [thernstig](https://github.com/thernstig/))
+   ([#6506](https://github.com/Microsoft/vscode-python/issues/6506))
+1. Provide user feedback when searching for a Jupyter server to use and allow the user to cancel this process.
+   ([#7262](https://github.com/Microsoft/vscode-python/issues/7262))
+1. By default, don't change matplotlib themes and place all plots on a white background regardless of VS Code theme. Add a setting to allow for plots to try to theme.
+   ([#8000](https://github.com/Microsoft/vscode-python/issues/8000))
+1. Prompt to open exported `Notebook` in the `Notebook Editor`.
+   ([#8078](https://github.com/Microsoft/vscode-python/issues/8078))
+1. Add commands translation for Farsi locale.
+   (thanks [Nikronic](https://github.com/Nikronic))
+   ([#8092](https://github.com/Microsoft/vscode-python/issues/8092))
+1. Enhance "select a workspace" message when selecting interpreter.
+   (thanks [Nikolay Kondratyev](https://github.com/kondratyev-nv/))
+   ([#8103](https://github.com/Microsoft/vscode-python/issues/8103))
+1. Add logging support for python debug adapter.
+   ([#8106](https://github.com/Microsoft/vscode-python/issues/8106))
+1. Style adjustments to line numbers (color and width) in the `Native Editor`, to line up with VS Code styles.
+   ([#8289](https://github.com/Microsoft/vscode-python/issues/8289))
+1. Added command translations for Turkish.
+   (thanks to [alioguzhan](https://github.com/alioguzhan/))
+   ([#8320](https://github.com/Microsoft/vscode-python/issues/8320))
+1. Toolbar was updated to take less space and be reached more easily.
+   ([#8366](https://github.com/Microsoft/vscode-python/issues/8366))
+
+### Fixes
+
+1. Fix running a unittest file executing only the first test.
+   (thanks [Nikolay Kondratyev](https://github.com/kondratyev-nv/))
+   ([#4567](https://github.com/Microsoft/vscode-python/issues/4567))
+1. Force the pytest root dir to always be the workspace root folder.
+   ([#6548](https://github.com/Microsoft/vscode-python/issues/6548))
+1. The notebook editor will now treat wrapped lines as different lines, so moving in cells and between cells with the arrow keys (and j and k) will be easier.
+   ([#7227](https://github.com/Microsoft/vscode-python/issues/7227))
+1. During test discovery, ignore tests generated by pytest plugins (like pep8).
+   Tests like that were causing discovery to fail.
+   ([#7287](https://github.com/Microsoft/vscode-python/issues/7287))
+1. When exporting a notebook editor to python script don't use the temp file location for generating the export.
+   ([#7567](https://github.com/Microsoft/vscode-python/issues/7567))
+1. Unicode symbol used to mark skipped tests was almost not visible on Linux and Windows.
+   ([#7705](https://github.com/Microsoft/vscode-python/issues/7705))
+1. Editing cells in a notebook, closing VS code, and then reopening will not have the cell content visible.
+   ([#7754](https://github.com/Microsoft/vscode-python/issues/7754))
+1. Sonar warnings.
+   ([#7812](https://github.com/Microsoft/vscode-python/issues/7812))
+1. Remove --ci flag from install_ptvsd.py to fix execution of "Setup" instructions from CONTRIBUTING.md.
+   ([#7814](https://github.com/Microsoft/vscode-python/issues/7814))
+1. Add telemetry for control groups in debug adapter experiments.
+   ([#7817](https://github.com/Microsoft/vscode-python/issues/7817))
+1. Allow the language server to pick a default caching mode.
+   ([#7821](https://github.com/Microsoft/vscode-python/issues/7821))
+1. Respect ignoreVSCodeTheme setting and correctly swap icons when changing from light to dark color themes.
+   ([#7847](https://github.com/Microsoft/vscode-python/issues/7847))
+1. 'Clear All Output' now deletes execution count for all cells.
+   ([#7853](https://github.com/Microsoft/vscode-python/issues/7853))
+1. If a Jupyter server fails to start, allow user to retry without having to restart VS code.
+   ([#7865](https://github.com/Microsoft/vscode-python/issues/7865))
+1. Fix strings of commas appearing in text/html output in the notebook editor.
+   ([#7873](https://github.com/Microsoft/vscode-python/issues/7873))
+1. When creating a new blank notebook, it has existing text in it already.
+   ([#7980](https://github.com/Microsoft/vscode-python/issues/7980))
+1. Can now include a LaTeX-style equation without surrounding the equation with '$' in a markdown cell.
+   ([#7992](https://github.com/Microsoft/vscode-python/issues/7992))
+1. Make a spinner appear during executing a cell.
+   ([#8003](https://github.com/Microsoft/vscode-python/issues/8003))
+1. Signature help is overflowing out of the signature help widget on the Notebook Editor.
+   ([#8006](https://github.com/Microsoft/vscode-python/issues/8006))
+1. Ensure intellisense (& similar widgets/popups) are dispaled for one cell in the Notebook editor.
+   ([#8007](https://github.com/Microsoft/vscode-python/issues/8007))
+1. Correctly restart Jupyter sessions when the active interpreter is changed.
+   ([#8019](https://github.com/Microsoft/vscode-python/issues/8019))
+1. Clear up wording around jupyterServerURI and remove the quick pick from the flow of setting that.
+   ([#8021](https://github.com/Microsoft/vscode-python/issues/8021))
+1. Use actual filename comparison for filename equality checks.
+   ([#8022](https://github.com/Microsoft/vscode-python/issues/8022))
+1. Opening a notebook a second time round with changes (made from another editor) should be preserved.
+   ([#8025](https://github.com/Microsoft/vscode-python/issues/8025))
+1. Minimize the GPU impact of the interactive window and the notebook editor.
+   ([#8039](https://github.com/Microsoft/vscode-python/issues/8039))
+1. Store version of the `Python` interpreter (kernel) in the notebook metadata when running cells.
+   ([#8064](https://github.com/Microsoft/vscode-python/issues/8064))
+1. Make shift+enter not take focus unless about to add a new cell.
+   ([#8069](https://github.com/Microsoft/vscode-python/issues/8069))
+1. When checking the version of `pandas`, use the same interpreter used to start `Jupyter`.
+   ([#8084](https://github.com/Microsoft/vscode-python/issues/8084))
+1. Make brackets and paranthesis auto complete in the Notebook Editor and Interactive Window (based on editor settings).
+   ([#8086](https://github.com/Microsoft/vscode-python/issues/8086))
+1. Cannot create more than one blank notebook.
+   ([#8132](https://github.com/Microsoft/vscode-python/issues/8132))
+1. Fix for code disappearing after switching between markdown and code in a Notebook Editor.
+   ([#8141](https://github.com/Microsoft/vscode-python/issues/8141))
+1. Support `⌘+s` keyboard shortcut for saving `Notebooks`.
+   ([#8151](https://github.com/Microsoft/vscode-python/issues/8151))
+1. Fix closing a Notebook Editor to actually wait for the kernel to restart.
+   ([#8167](https://github.com/Microsoft/vscode-python/issues/8167))
+1. Inserting a cell in a notebook can sometimes cause the contents to be the cell below it.
+   ([#8194](https://github.com/Microsoft/vscode-python/issues/8194))
+1. Scroll the notebook editor when giving focus or changing line of a code cell.
+   ([#8205](https://github.com/Microsoft/vscode-python/issues/8205))
+1. Prevent code from changing in the Notebook Editor while running a cell.
+   ([#8215](https://github.com/Microsoft/vscode-python/issues/8215))
+1. When updating the Python extension, unsaved changes to notebooks are lost.
+   ([#8263](https://github.com/Microsoft/vscode-python/issues/8263))
+1. Fix CI to use Python 3.7.5.
+   ([#8296](https://github.com/Microsoft/vscode-python/issues/8296))
+1. Correctly transition markdown cells into code cells.
+   ([#8386](https://github.com/Microsoft/vscode-python/issues/8386))
+
+### Code Health
+
+1. Add unit tests for src/client/common/process/pythonProcess.ts.
+   ([#6065](https://github.com/Microsoft/vscode-python/issues/6065))
+1. Remove try...catch around use of vscode.env.shell.
+   ([#6912](https://github.com/Microsoft/vscode-python/issues/6912))
+1. Test plan needed to be updated to include support for the Notebook Editor.
+   ([#7593](https://github.com/Microsoft/vscode-python/issues/7593))
+1. Add test step to get correct pywin32 installed with python 3.6 on windows.
+   ([#7798](https://github.com/Microsoft/vscode-python/issues/7798))
+1. Update Test Explorer icons to match new VS Code icons.
+   ([#7809](https://github.com/Microsoft/vscode-python/issues/7809))
+1. Fix native editor mime type functional test.
+   ([#7877](https://github.com/Microsoft/vscode-python/issues/7877))
+1. Fix variable explorer loading test.
+   ([#7878](https://github.com/Microsoft/vscode-python/issues/7878))
+1. Add telemetry to capture usage of features in the `Notebook Editor` for `Data Science` features.
+   ([#7908](https://github.com/Microsoft/vscode-python/issues/7908))
+1. Fix debug temporary functional test for Mac / Linux.
+   ([#7994](https://github.com/Microsoft/vscode-python/issues/7994))
+1. Variable explorer tests failing on nightly.
+   ([#8124](https://github.com/Microsoft/vscode-python/issues/8124))
+1. Timeout with new waitForMessage in native editor tests.
+   ([#8255](https://github.com/Microsoft/vscode-python/issues/8255))
+1. Remove code used to track perf of creation classes.
+   ([#8280](https://github.com/Microsoft/vscode-python/issues/8280))
+1. Update TypeScript to `3.7`.
+   ([#8395](https://github.com/Microsoft/vscode-python/issues/8395))
+
+### Thanks
+
+Thanks to the following projects which we fully rely on to provide some of
+our features:
+- [isort](https://pypi.org/project/isort/)
+- [jedi](https://pypi.org/project/jedi/)
+  and [parso](https://pypi.org/project/parso/)
+- [Microsoft Python Language Server](https://github.com/microsoft/python-language-server)
+- [ptvsd](https://pypi.org/project/ptvsd/)
+- [pyparsing](https://pypi.org/project/pyparsing/)
+- [exuberant ctags](http://ctags.sourceforge.net/) (user-installed)
+- [rope](https://pypi.org/project/rope/) (user-installed)
+
+Also thanks to the various projects we provide integrations with which help
+make this extension useful:
+- Debugging support:
+  [Django](https://pypi.org/project/Django/),
+  [Flask](https://pypi.org/project/Flask/),
+  [gevent](https://pypi.org/project/gevent/),
+  [Jinja](https://pypi.org/project/Jinja/),
+  [Pyramid](https://pypi.org/project/pyramid/),
+  [PySpark](https://pypi.org/project/pyspark/),
+  [Scrapy](https://pypi.org/project/Scrapy/),
+  [Watson](https://pypi.org/project/Watson/)
+- Formatting:
+  [autopep8](https://pypi.org/project/autopep8/),
+  [black](https://pypi.org/project/black/),
+  [yapf](https://pypi.org/project/yapf/)
+- Interpreter support:
+  [conda](https://conda.io/),
+  [direnv](https://direnv.net/),
+  [pipenv](https://pypi.org/project/pipenv/),
+  [pyenv](https://github.com/pyenv/pyenv),
+  [venv](https://docs.python.org/3/library/venv.html#module-venv),
+  [virtualenv](https://pypi.org/project/virtualenv/)
+- Linting:
+  [bandit](https://pypi.org/project/bandit/),
+  [flake8](https://pypi.org/project/flake8/),
+  [mypy](https://pypi.org/project/mypy/),
+  [prospector](https://pypi.org/project/prospector/),
+  [pylint](https://pypi.org/project/pylint/),
+  [pydocstyle](https://pypi.org/project/pydocstyle/),
+  [pylama](https://pypi.org/project/pylama/)
+- Testing:
+  [nose](https://pypi.org/project/nose/),
+  [pytest](https://pypi.org/project/pytest/),
+  [unittest](https://docs.python.org/3/library/unittest.html#module-unittest)
+
+And finally thanks to the [Python](https://www.python.org/) development team and
+community for creating a fantastic programming language and community to be a
+part of!
+
 ## 2019.10.1 (22 October 2019)
 
 ### Enhancements
@@ -66,6 +261,56 @@
 1. Use `Webview.asWebviewUri` to generate a URI for use in the `Webview Panel` instead of hardcoding the resource `vscode-resource`.
    ([#7834](https://github.com/Microsoft/vscode-python/issues/7834))
 
+### Thanks
+
+Thanks to the following projects which we fully rely on to provide some of
+our features:
+- [isort](https://pypi.org/project/isort/)
+- [jedi](https://pypi.org/project/jedi/)
+  and [parso](https://pypi.org/project/parso/)
+- [Microsoft Python Language Server](https://github.com/microsoft/python-language-server)
+- [ptvsd](https://pypi.org/project/ptvsd/)
+- [exuberant ctags](http://ctags.sourceforge.net/) (user-installed)
+- [rope](https://pypi.org/project/rope/) (user-installed)
+
+Also thanks to the various projects we provide integrations with which help
+make this extension useful:
+- Debugging support:
+  [Django](https://pypi.org/project/Django/),
+  [Flask](https://pypi.org/project/Flask/),
+  [gevent](https://pypi.org/project/gevent/),
+  [Jinja](https://pypi.org/project/Jinja/),
+  [Pyramid](https://pypi.org/project/pyramid/),
+  [PySpark](https://pypi.org/project/pyspark/),
+  [Scrapy](https://pypi.org/project/Scrapy/),
+  [Watson](https://pypi.org/project/Watson/)
+- Formatting:
+  [autopep8](https://pypi.org/project/autopep8/),
+  [black](https://pypi.org/project/black/),
+  [yapf](https://pypi.org/project/yapf/)
+- Interpreter support:
+  [conda](https://conda.io/),
+  [direnv](https://direnv.net/),
+  [pipenv](https://pypi.org/project/pipenv/),
+  [pyenv](https://github.com/pyenv/pyenv),
+  [venv](https://docs.python.org/3/library/venv.html#module-venv),
+  [virtualenv](https://pypi.org/project/virtualenv/)
+- Linting:
+  [bandit](https://pypi.org/project/bandit/),
+  [flake8](https://pypi.org/project/flake8/),
+  [mypy](https://pypi.org/project/mypy/),
+  [prospector](https://pypi.org/project/prospector/),
+  [pylint](https://pypi.org/project/pylint/),
+  [pydocstyle](https://pypi.org/project/pydocstyle/),
+  [pylama](https://pypi.org/project/pylama/)
+- Testing:
+  [nose](https://pypi.org/project/nose/),
+  [pytest](https://pypi.org/project/pytest/),
+  [unittest](https://docs.python.org/3/library/unittest.html#module-unittest)
+
+And finally thanks to the [Python](https://www.python.org/) development team and
+community for creating a fantastic programming language and community to be a
+part of!
 
 ## 2019.10.0 (8 October 2019)
 
@@ -4221,4 +4466,4 @@ the following people who contributed code:
 * Added ability to view global variables, arguments, add and remove break points
 
 ## Version 0.0.3
-* Added support for debugging using PDB
+* Added support for debugging using PDB