Skip to content

Conversation

luabud
Copy link
Member

@luabud luabud commented Nov 12, 2019

For #8539

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@luabud luabud added the no-changelog No news entry required label Nov 12, 2019
@luabud luabud changed the title Rename debug adapter experiment group Adjust debug adapter experiment before release Nov 12, 2019
@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #8540 into master will increase coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8540      +/-   ##
==========================================
+ Coverage   59.04%   59.37%   +0.32%     
==========================================
  Files         511      511              
  Lines       23669    23676       +7     
  Branches     3823     3829       +6     
==========================================
+ Hits        13976    14058      +82     
+ Misses       8773     8699      -74     
+ Partials      920      919       -1
Impacted Files Coverage Δ
src/client/common/experimentGroups.ts 100% <100%> (ø) ⬆️
src/client/debugger/extension/adapter/factory.ts 92.98% <0%> (-1.14%) ⬇️
src/client/datascience/jupyter/jupyterDebugger.ts 10.47% <0%> (ø) ⬆️
src/client/telemetry/constants.ts 100% <0%> (ø) ⬆️
src/client/telemetry/index.ts 87.12% <0%> (+0.99%) ⬆️
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 70.51% <0%> (+12.82%) ⬆️
src/client/api.ts 92.85% <0%> (+14.28%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4303d8e...4a4f3d7. Read the comment docs.

@luabud luabud marked this pull request as ready for review November 12, 2019 20:38
@luabud luabud merged commit 485c7c5 into microsoft:master Nov 13, 2019
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Nov 13, 2019
* Rename debug adapter experiment group

* Adjust experiment numbers to 20% in debug adapter experiment and 7% in wheels experiment

* Revert "Adjust experiment numbers to 20% in debug adapter experiment and 7% in wheels experiment"

This reverts commit ee8db47.

* Shutting off experiments pre-release
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Nov 13, 2019
* Rename debug adapter experiment group

* Adjust experiment numbers to 20% in debug adapter experiment and 7% in wheels experiment

* Revert "Adjust experiment numbers to 20% in debug adapter experiment and 7% in wheels experiment"

This reverts commit ee8db47.

* Shutting off experiments pre-release
@lock lock bot locked as resolved and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants