fix blue color on export icon #8449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
approved these changes
Nov 7, 2019
IanMatthewHuff
commented
Nov 7, 2019
| <Image baseTheme={this.state.baseTheme} class='image-button-image' image={ImageName.SaveAs} /> | ||
| </ImageButton> | ||
| <ImageButton baseTheme={this.state.baseTheme} onClick={this.stateController.export} disabled={!this.stateController.canExport()} className='save-button' tooltip={getLocString('DataScience.exportAsPythonFileTooltip', 'Save As Python File')}> | ||
| <ImageButton baseTheme={this.state.baseTheme} onClick={this.stateController.export} disabled={!this.stateController.canExport()} className='native-button' tooltip={getLocString('DataScience.exportAsPythonFileTooltip', 'Save As Python File')}> |
There was a problem hiding this comment.
It's funny, I think this issue always existed, but was just exposed by some recent changes to the css ordering.
DavidKutu
approved these changes
Nov 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #8449 +/- ##
==========================================
- Coverage 59.46% 59.14% -0.33%
==========================================
Files 509 509
Lines 23390 23390
Branches 3779 3774 -5
==========================================
- Hits 13909 13834 -75
- Misses 8575 8650 +75
Partials 906 906
Continue to review full report at Codecov.
|
IanMatthewHuff
added a commit
to IanMatthewHuff/vscode-python
that referenced
this pull request
Nov 8, 2019
10 tasks
IanMatthewHuff
added a commit
that referenced
this pull request
Nov 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8424
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)