Remove try...catch around use of vscode.env.shell #8413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 6, 2019 13:27
Codecov Report
@@ Coverage Diff @@
## master #8413 +/- ##
==========================================
- Coverage 59.46% 59.14% -0.32%
==========================================
Files 509 509
Lines 23393 23390 -3
Branches 3779 3774 -5
==========================================
- Hits 13910 13834 -76
- Misses 8577 8650 +73
Partials 906 906
Continue to review full report at Codecov.
|
karrtikr
requested review from
kimadeline,
ericsnowcurrently and
karthiknadig
kimadeline
reviewed
Nov 6, 2019
kimadeline
reviewed
Nov 7, 2019
| @@ -85,11 +85,11 @@ suite('Shell Detectors', () => { | |||
| test('Identify shell based on VSC Environment', async () => { | |||
| const shellDetector = new VSCEnvironmentShellDetector(instance(appEnv)); | |||
| shellPathsAndIdentification.forEach((shellType, shellPath) => { | |||
| when(appEnv.shell).thenReturn(shellPath); | |||
| when(appEnv.shell).thenReturn(shellPath as any); | |||
There was a problem hiding this comment.
you shouldn't need this as any either 🤔
There was a problem hiding this comment.
Both my eyes were closed when I added this🥱 sorry
kimadeline
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6912