Skip to content

Conversation

DavidKutu
Copy link

For #8445

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@DavidKutu DavidKutu added the no-changelog No news entry required label Nov 7, 2019
@DavidKutu DavidKutu self-assigned this Nov 7, 2019
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #8450 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8450   +/-   ##
=======================================
  Coverage   59.46%   59.46%           
=======================================
  Files         509      509           
  Lines       23390    23390           
  Branches     3779     3779           
=======================================
  Hits        13909    13909           
  Misses       8575     8575           
  Partials      906      906

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45bffa8...b24ffce. Read the comment docs.

@DavidKutu DavidKutu merged commit f408a53 into master Nov 7, 2019
@DavidKutu DavidKutu deleted the davidkutu/increasing_indent_fix branch November 7, 2019 22:58
@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants