-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fixes to Jupyter daemon and refactor jupyter commands #8469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to Jupyter daemon and refactor jupyter commands #8469
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8469 +/- ##
==========================================
- Coverage 59.39% 59.09% -0.31%
==========================================
Files 509 510 +1
Lines 23423 23561 +138
Branches 3786 3813 +27
==========================================
+ Hits 13913 13924 +11
- Misses 8604 8729 +125
- Partials 906 908 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For #7242
(daemon is not used in this PR, wanted to get some other refactorings and fixes out before integrating the daemon. Smaller set of changes easier to review).