Skip to content

Conversation

DonJayamanne
Copy link

For #7242

  • Refactor Jupyter Commands
  • Fixes to Jupyter daemon

(daemon is not used in this PR, wanted to get some other refactorings and fixes out before integrating the daemon. Smaller set of changes easier to review).

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Nov 8, 2019
@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #8469 into master will decrease coverage by 0.3%.
The diff coverage is 67.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8469      +/-   ##
==========================================
- Coverage   59.39%   59.09%   -0.31%     
==========================================
  Files         509      510       +1     
  Lines       23423    23561     +138     
  Branches     3786     3813      +27     
==========================================
+ Hits        13913    13924      +11     
- Misses       8604     8729     +125     
- Partials      906      908       +2
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø) ⬆️
src/client/common/process/types.ts 100% <ø> (ø) ⬆️
src/client/common/process/pythonDaemon.ts 7.69% <0%> (ø)
src/client/datascience/jupyter/jupyterCommand.ts 95.65% <100%> (+0.41%) ⬆️
...rc/client/common/process/pythonExecutionFactory.ts 53.42% <20%> (-0.87%) ⬇️
...client/datascience/jupyter/jupyterCommandFinder.ts 73.59% <74.07%> (-1.81%) ⬇️
...lient/interpreter/locators/services/condaHelper.ts 90.62% <0%> (-0.56%) ⬇️
...mentActivationProviders/condaActivationProvider.ts 94.23% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6295bee...693d7fe. Read the comment docs.

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne reopened this Nov 9, 2019
@DonJayamanne DonJayamanne merged commit c027287 into microsoft:master Nov 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants