Skip to content

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Nov 18, 2019

For #7221

The more general case here is to support clicking on all sorts of links.

@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #8651 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8651      +/-   ##
==========================================
+ Coverage   59.11%   59.11%   +<.01%     
==========================================
  Files         520      520              
  Lines       23938    23940       +2     
  Branches     3870     3870              
==========================================
+ Hits        14150    14152       +2     
  Misses       8869     8869              
  Partials      919      919
Impacted Files Coverage Δ
...tascience-ui/history-react/redux/reducers/index.ts 0% <ø> (ø) ⬆️
...tascience-ui/native-editor/redux/reducers/index.ts 0% <ø> (ø) ⬆️
src/datascience-ui/history-react/redux/actions.ts 0% <0%> (ø) ⬆️
src/datascience-ui/native-editor/redux/actions.ts 0% <0%> (ø) ⬆️
src/client/common/utils/localize.ts 94.04% <100%> (+0.01%) ⬆️
...ience/interactive-common/interactiveWindowTypes.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358b7d2...33da955. Read the comment docs.

@rchiodo rchiodo merged commit f3a32e7 into master Nov 19, 2019
@rchiodo rchiodo deleted the rchiodo/download_plotly branch November 19, 2019 00:13
@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants