Skip to content

Conversation

kondratyev-nv
Copy link

For #4567

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Oct 5, 2019

Codecov Report

Merging #7783 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7783      +/-   ##
==========================================
+ Coverage   59.33%   59.33%   +<.01%     
==========================================
  Files         505      505              
  Lines       23147    23148       +1     
  Branches     3745     3745              
==========================================
+ Hits        13734    13735       +1     
  Misses       8520     8520              
  Partials      893      893
Impacted Files Coverage Δ
.../client/testing/unittest/services/parserService.ts 95.23% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e7bce4...2c29247. Read the comment docs.

@kondratyev-nv
Copy link
Author

@kimadeline @ericsnowcurrently Just a kindly reminder :) Are there any chances for this PR to be reviewed?

@kimadeline
Copy link

Hi @kondratyev-nv , thank you for your PR! We'll get to it as soon as we can.

Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm going to run a full CI pass on this PR before merging.

@ericsnowcurrently
Copy link

CI results look fine.

@ericsnowcurrently ericsnowcurrently merged commit 83d0cc6 into microsoft:master Nov 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 13, 2019
@kondratyev-nv kondratyev-nv deleted the master branch August 6, 2021 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants