Skip to content

Conversation

DonJayamanne
Copy link

For #7242

@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #8543 into master will increase coverage by 0.07%.
The diff coverage is 88.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8543      +/-   ##
==========================================
+ Coverage   58.71%   58.78%   +0.07%     
==========================================
  Files         511      512       +1     
  Lines       23306    23386      +80     
  Branches     3824     3837      +13     
==========================================
+ Hits        13684    13748      +64     
- Misses       8703     8716      +13     
- Partials      919      922       +3
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø) ⬆️
...datascience/jupyter/liveshare/hostJupyterServer.ts 16.04% <0%> (ø) ⬆️
src/client/datascience/jupyter/jupyterCommand.ts 96.42% <100%> (+0.77%) ⬆️
...client/datascience/jupyter/jupyterCommandFinder.ts 73.43% <100%> (-0.17%) ⬇️
src/client/datascience/activation.ts 92% <100%> (ø)
src/client/datascience/jupyter/jupyterExecution.ts 50.69% <100%> (ø) ⬆️
...rc/client/common/process/pythonExecutionFactory.ts 93.44% <100%> (+0.46%) ⬆️
src/client/datascience/jupyter/notebookStarter.ts 63.88% <74.07%> (-0.4%) ⬇️
...ascience/interactive-ipynb/nativeEditorProvider.ts 53.96% <75%> (+0.3%) ⬆️
...ient/datascience/interactive-ipynb/nativeEditor.ts 57.64% <0%> (-1.13%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0e14d...effe640. Read the comment docs.

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne marked this pull request as ready for review November 13, 2019 19:11
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit 77866a1 into microsoft:master Nov 14, 2019
@DonJayamanne DonJayamanne deleted the refactorForSingleProc branch November 14, 2019 17:32
@lock lock bot locked as resolved and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants