Skip to content

Refactor GIDGoogleUser public API #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Alex-4-Git merged 24 commits into from
Nov 10, 2022
Merged

Refactor GIDGoogleUser public API #249

Alex-4-Git merged 24 commits into from
Nov 10, 2022

Conversation

@Alex-4-Git
Copy link
Contributor

@Alex-4-Git Alex-4-Git commented Nov 2, 2022 •
edited
Loading

Important changes

  • Move GIDAuthentication public API into GIDGoogleUser. Remove GIDAuthentication public classes. Only keep
    GIDAuthentication private for encoding backward compatibility.
  • Move addScopes: from GIDSignIn public API to GIDGoogleUser public API.

Manual testing

  • Tested DaysUntilBirthday(mac) on mac.
  • Tested DaysUntilBirthday(iOS) on Xcode simulators and real device (iPhone 11, iOS 15).

Alex-4-Git and others added 22 commits August 3, 2022 11:20
@Alex-4-Git
Create branch GIDGoogleUser-restructure to track PRs relating to GIDG…
bfc16c5 
…oogleUser
@Alex-4-Git
Create class GIDUserAuth (#177)
58f62d5 
* Create class GIDUserAuth

Add class GIDUserAuth to represent the outcome of a successful signIn or addScopes flow.
@Alex-4-Git
Replace GIDSignInCallback (#179)
3ba23d0 
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
@Alex-4-Git
Add GIDToken Class (#181)
b6c6b8b 
Add GIDToken class
@Alex-4-Git
Add the property configuration to GIDGoogleUser (#183)
e5958f8 
* Add the property GIDConfiguration to GIDGoogleUser

- Add a GIDConfiguration to replace hostedDomain, serverClientID, openRealm.
- Remove the property serverAuthCode.
@Alex-4-Git
Replace GIDSignInCallback (#179)
ada3203 
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
@Alex-4-Git
Add Three token properties in GIDGoogleUser API (#189)
5c8fa73 
Add three tokens in GIDGoogleUser API
@Alex-4-Git
Merge branch 'main' into GIDGoogleUser-restructure
c8060d3
@Alex-4-Git
Add unit test for updateAuthState: in GIDGoogleUserTest (#212)
3e54f09 
- Add a new initializer in OIDAuthState+Testing.
- Add a test case `testUpdateAuthState`.
@Alex-4-Git
Merge branch 'main' into GIDGoogleUser-restructure
c0706ec
@Alex-4-Git
Use NSTimeIntervalSince1970 to replace timeIntervalSinceReferenceDate (…
89b3ed8 
…#227)
@Alex-4-Git
Make tokens in GIDGoogleUser KVO-compliant (#222)
405dc51
@Alex-4-Git
Use accessTokenExpiresIn to replace accessTokenExpireTime in tests (#229
2c833ce 
)

Apply the time interval `expiresIn` on both access token and id token.
@Alex-4-Git
Move the fetcher authorizer into GIDGoogleUser API (#230)
64b35f8
@Alex-4-Git
Add unit tests for GIDEMMSupport (#236)
18c65c0
@Alex-4-Git
Move the method doWithFreshTokens: into GIDGoogleUserAPI (#234)
e43bd7f
@Alex-4-Git
Merge branch 'main' into GIDGoogleUser-restructure
bb2b7d8
@Alex-4-Git
Fix the signInSample app (#238)
d6f42bc
@Alex-4-Git
Move the method addScopes into GIDGoogleUser API (#239)
114a0ac
@Alex-4-Git
Merge branch 'main' into GIDGoogleUser-restructure
8de36b5
@Alex-4-Git
Rename the GIDGoogleUser method doWithFreshTokens: (#242)
828ea1f
@Alex-4-Git
Merge branch 'main' into GIDGoogleUser-restructure
5ddc638
@petea petea added this to the 7.0.0 milestone Nov 3, 2022
@Alex-4-Git Alex-4-Git marked this pull request as ready for review November 4, 2022 22:59
@Alex-4-Git Alex-4-Git requested review from mdmathias and petea November 4, 2022 23:00
@petea
Copy link
Contributor

petea commented Nov 8, 2022

@Alex-4-Git can you add to the PR description a brief explanation of the manual testing you've performed on this PR to confirm that the new API surface is working as expected?

petea
petea approved these changes Nov 8, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git merged commit 87eddac into main Nov 10, 2022
@Alex-4-Git Alex-4-Git deleted the GIDGoogleUser-restructure branch November 10, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathias mdmathias Awaiting requested review from mdmathias

1 more reviewer

@petea petea petea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Alex-4-Git @petea