Skip to content

Make tokens in GIDGoogleUser KVO-compliant #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Alex-4-Git merged 9 commits into from
Sep 26, 2022
Merged

Make tokens in GIDGoogleUser KVO-compliant #222

Alex-4-Git merged 9 commits into from
Sep 26, 2022

Conversation

@Alex-4-Git
Copy link
Contributor

@Alex-4-Git Alex-4-Git commented Sep 20, 2022 •
edited
Loading

To be consistent with GIDAuthentication, the token properties in GIDGoogleUser should be KVO-compliant.

@Alex-4-Git
Add KVO in GIDGoogleUser
30699df 
Send KVO notifications when authState updates tokens.
@Alex-4-Git Alex-4-Git force-pushed the pin-AddKVOInGoogleUser branch from 8ded172 to e5b6c13 Compare September 20, 2022 18:23
@Alex-4-Git
Observe KVO in GIDGoogleUserTest
9ac5478 
Uses bit mask to verify KVO notifications are sent.
@Alex-4-Git Alex-4-Git force-pushed the pin-AddKVOInGoogleUser branch from e5b6c13 to 9ac5478 Compare September 20, 2022 20:42
petea
petea reviewed Sep 22, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from petea September 22, 2022 18:21
petea
petea suggested changes Sep 22, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from petea September 22, 2022 20:37
@Alex-4-Git
Remove the KVO testing
d45e398 
Since we use NSObject automatic change notifications we can remove the tests for manual notifications emission.
@Alex-4-Git Alex-4-Git force-pushed the pin-AddKVOInGoogleUser branch from 6a69d8b to d45e398 Compare September 22, 2022 21:31
petea
petea suggested changes Sep 23, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from petea September 23, 2022 22:11
@Alex-4-Git
Test tokens unchanged
9d5f7db 
Added a new test case `testUpdateAuthState_tokensAreNotChanged `
@Alex-4-Git Alex-4-Git force-pushed the pin-AddKVOInGoogleUser branch from a56786b to 9d5f7db Compare September 26, 2022 08:42
petea
petea approved these changes Sep 26, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git merged commit 405dc51 into GIDGoogleUser-restructure Sep 26, 2022
@Alex-4-Git Alex-4-Git deleted the pin-AddKVOInGoogleUser branch September 26, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathias mdmathias Awaiting requested review from mdmathias

1 more reviewer

@petea petea petea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alex-4-Git @petea