Move the fetcher authorizer into GIDGoogleUser API #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send KVO notifications when authState updates tokens.
Uses bit mask to verify KVO notifications are sent.
…ogleSignIn-iOS into pin-AddKVOInGoogleUser
Since we use NSObject automatic change notifications we can remove the tests for manual notifications emission.
Added a new test case `testUpdateAuthStateWithUnchangedRefreshTokenAndIDToken `
Alex-4-Git
force-pushed
the
pin-moveFetcherAuthorizaer
branch
2 times, most recently
from
3f26081 to
296c45c
Compare
Alex-4-Git
force-pushed
the
pin-moveFetcherAuthorizaer
branch
from
296c45c to
3d29212
Compare
petea
suggested changes
Sep 28, 2022
mdmathias
reviewed
Sep 28, 2022
Alex-4-Git
force-pushed
the
pin-moveFetcherAuthorizaer
branch
from
056b1a9 to
ad40f6c
Compare
mdmathias
reviewed
Sep 29, 2022
GoogleSignIn/Sources/GIDAppAuthFetcherAuthorizationWithEMMSupport.m
Outdated
Show resolved
Hide resolved
petea
suggested changes
Sep 30, 2022
GoogleSignIn/Sources/GIDAppAuthFetcherAuthorizationWithEMMSupport.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAppAuthFetcherAuthorizationWithEMMSupport.h
Outdated
Show resolved
Hide resolved
Alex-4-Git
force-pushed
the
pin-moveFetcherAuthorizaer
branch
from
1c015f3 to
51bb424
Compare
XiangtianDai
reviewed
Oct 3, 2022
XiangtianDai
approved these changes
Oct 3, 2022
mdmathias
approved these changes
Oct 3, 2022
petea
approved these changes
Oct 3, 2022
GoogleSignIn/Sources/GIDAppAuthFetcherAuthorizationWithEMMSupport.m
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the part of the refactor plan - merge GIDAuthentication into GIDGoogleUser.
fetcherAuthorizerinto GIDGoogleUser public API.