Create class GIDUserAuth #177
Conversation
Add class GIDUserAuth to represent the outcome of a successful signIn or addScopes flow.
| /// An OAuth2 authorization code for the home server. | ||
| @property(nonatomic, readonly, nullable) NSString *serverAuthCode; | ||
|
|
||
| + (instancetype)new NS_UNAVAILABLE; |
There was a problem hiding this comment.
Is it worth documenting here how this type is supposed to be created?
There was a problem hiding this comment.
I think we don't need to document that. For our clients they only need to read the data inside this class. I will add unsupported here.
There was a problem hiding this comment.
I don't think /// Unsupported. adds much. It'd be more helpful to have something like (for this and init below):
Unavailable. See the internally scoped -[GIDUserAuth_Private initWithGoogleUser:serverAuthCode:] to create an instance.
There was a problem hiding this comment.
This is a public API. There is no benefit if we tell them how to create this instance because we don't want them to do it.
There was a problem hiding this comment.
Fair enough. I don't think /// Unsupported. is useful. Feel free to remove.
* Create class GIDUserAuth Add class GIDUserAuth to represent the outcome of a successful signIn or addScopes flow.
* Create class GIDUserAuth Add class GIDUserAuth to represent the outcome of a successful signIn or addScopes flow.
2 participants
Add class GIDUserAuth to represent the outcome of a successful signIn or addScopes flow.