Skip to content

Move the method addScopes into GIDGoogleUser API #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Alex-4-Git merged 14 commits into from
Oct 28, 2022
Merged

Move the method addScopes into GIDGoogleUser API #239

Alex-4-Git merged 14 commits into from
Oct 28, 2022

Conversation

@Alex-4-Git
Copy link
Contributor

@Alex-4-Git Alex-4-Git commented Oct 14, 2022

  • add addScopes in GIDGoogleUser.h
  • move `addScopes' from GIDSignIn.h to GIDSignIn_Private.h

@Alex-4-Git Alex-4-Git changed the base branch from main to GIDGoogleUser-restructure October 14, 2022 23:50
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDGoogleUserAddScopes branch from 654a5fe to ba4095f Compare October 14, 2022 23:53
@Alex-4-Git Alex-4-Git marked this pull request as ready for review October 17, 2022 18:48
mdmathias
mdmathias reviewed Oct 17, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git requested review from mdmathias and petea October 17, 2022 23:12
mdmathias
mdmathias approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@mdmathias mdmathias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two little nits/questions. LGTM.

petea
petea suggested changes Oct 19, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDGoogleUserAddScopes branch from 5bfe213 to 12cb754 Compare October 20, 2022 23:52
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDGoogleUserAddScopes branch from 12cb754 to 8c4d954 Compare October 21, 2022 00:05
@Alex-4-Git Alex-4-Git requested a review from petea October 21, 2022 00:24
petea
petea suggested changes Oct 25, 2022
View reviewed changes
ch40w31
ch40w31 requested changes Oct 25, 2022
View reviewed changes
ch40w31
ch40w31 reviewed Oct 26, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from ch40w31 October 26, 2022 22:10
petea
petea approved these changes Oct 28, 2022
View reviewed changes
ch40w31
ch40w31 reviewed Oct 28, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from ch40w31 October 28, 2022 20:40
@Alex-4-Git Alex-4-Git merged commit 114a0ac into GIDGoogleUser-restructure Oct 28, 2022
@Alex-4-Git Alex-4-Git deleted the pin-GIDGoogleUserAddScopes branch October 28, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ch40w31 ch40w31 ch40w31 approved these changes

@mdmathias mdmathias Awaiting requested review from mdmathias

+1 more reviewer

@petea petea petea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Alex-4-Git @petea @mdmathias @ch40w31