Skip to content

Rename the GIDGoogleUser method doWithFreshTokens: #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Alex-4-Git merged 10 commits into from
Nov 2, 2022
Merged

Rename the GIDGoogleUser method doWithFreshTokens: #242

Alex-4-Git merged 10 commits into from
Nov 2, 2022

Conversation

@Alex-4-Git
Copy link
Contributor

@Alex-4-Git Alex-4-Git commented Oct 18, 2022 •
edited
Loading

The objc API method doWithFreshTokens translates into do in Swift which is not understandable well.
In this PR we change this to refreshTokensIfNeededWithCompletion so in Swift client can use it as refreshTokensIfNeeded(completion:)

@Alex-4-Git Alex-4-Git changed the base branch from GIDGoogleUser-restructure to pin-GIDGoogleUserAddScopes October 18, 2022 17:53
@Alex-4-Git Alex-4-Git changed the base branch from pin-GIDGoogleUserAddScopes to GIDGoogleUser-restructure October 18, 2022 17:54
@Alex-4-Git Alex-4-Git force-pushed the pin-renameDoWithFreshToken branch from 2763167 to 30f938d Compare October 28, 2022 21:56
@Alex-4-Git Alex-4-Git marked this pull request as ready for review October 28, 2022 22:19
@Alex-4-Git Alex-4-Git requested review from mdmathias and petea October 28, 2022 22:19
petea
petea reviewed Oct 28, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from petea October 30, 2022 21:32
petea
petea reviewed Oct 31, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from petea October 31, 2022 23:01
@petea petea changed the title Rename the GIDGoogleUser API doWithFreshTokens: Rename the GIDGoogleUser method doWithFreshTokens: Nov 1, 2022
@Alex-4-Git Alex-4-Git merged commit 828ea1f into GIDGoogleUser-restructure Nov 2, 2022
@Alex-4-Git Alex-4-Git deleted the pin-renameDoWithFreshToken branch November 2, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathias mdmathias mdmathias approved these changes

+1 more reviewer

@petea petea petea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alex-4-Git @petea @mdmathias