Add Three token properties in GIDGoogleUser API #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-4-Git
force-pushed
the
pin-removeGIDAuthentication
branch
3 times, most recently
from
fbdcea6 to
09672e8
Compare
Collaborator
|
It might be beneficial in the future to add some more context in your PR description. Off the top of my head, I'm not sure why we want to add the these three token properties. I can go looking for context to help, but it'd be nice to have it here too. Moreover, I think we are all much less likely to remember, or be able to find, this context if we return to this PR in the future. |
mdmathias
reviewed
Jul 29, 2022
Alex-4-Git
force-pushed
the
pin-removeGIDAuthentication
branch
from
54c24b0 to
a495e24
Compare
mdmathias
reviewed
Aug 1, 2022
mdmathias
reviewed
Aug 1, 2022
petea
suggested changes
Aug 1, 2022
petea
suggested changes
Aug 2, 2022
mdmathias
approved these changes
Aug 3, 2022
Alex-4-Git
force-pushed
the
pin-removeGIDAuthentication
branch
from
858c710 to
02f9af5
Compare
* Create class GIDUserAuth Add class GIDUserAuth to represent the outcome of a successful signIn or addScopes flow.
Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Add GIDToken class
* Add the property GIDConfiguration to GIDGoogleUser - Add a GIDConfiguration to replace hostedDomain, serverClientID, openRealm. - Remove the property serverAuthCode.
Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git
force-pushed
the
pin-removeGIDAuthentication
branch
from
02f9af5 to
9dcff47
Compare
Alex-4-Git
force-pushed
the
GIDGoogleUser-restructure
branch
from
331202d to
ada3203
Compare
Alex-4-Git
force-pushed
the
pin-removeGIDAuthentication
branch
from
312f45a to
d86d5a9
Compare
petea
suggested changes
Aug 4, 2022
petea
suggested changes
Aug 8, 2022
1. Add property getters in GIDGoogleUser to match the pattern of GIDConfiguration 2. Use copy on the string parsed from authState.
petea
suggested changes
Aug 9, 2022
petea
suggested changes
Aug 11, 2022
petea
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the token related properties from GIDAuthentication.h to GIDGoogleUser.h.
In the previous PR we created the new class GIDToken. We can use this new type to add three tokens: access token, refresh token and ID token.