Replace GIDSignInCallback #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
mdmathias
requested changes
Jul 12, 2022
1. Resolve comments 2. Make sure in clients callback one of userAuth and error is nil.
petea
suggested changes
Jul 13, 2022
mdmathias
approved these changes
Jul 14, 2022
petea
suggested changes
Jul 14, 2022
Alex-4-Git
force-pushed
the
pin-ReplaceGIDSignInCallback
branch
from
d885189 to
b0dc952
Compare
Alex-4-Git
force-pushed
the
pin-ReplaceGIDSignInCallback
branch
from
b0dc952 to
2059e64
Compare
petea
approved these changes
Jul 15, 2022
GoogleSignIn/Sources/GIDSignIn.m
Outdated
GoogleSignIn/Sources/GIDSignIn.m
Outdated
Contributor
There was a problem hiding this comment.
I'd suggest renaming this GIDUserAuthCallback and moving it to GIDSignIn_Private.h so that you can use it in GIDSignInInternalOptions and elsewhere.
Alex-4-Git
force-pushed
the
pin-ReplaceGIDSignInCallback
branch
from
2059e64 to
ba214ce
Compare
Alex-4-Git
added a commit
that referenced
this pull request
Aug 3, 2022
Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git
added a commit
that referenced
this pull request
Aug 3, 2022
Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git
added a commit
that referenced
this pull request
Aug 3, 2022
Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git
added a commit
that referenced
this pull request
Aug 3, 2022
Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git
added a commit
that referenced
this pull request
Aug 11, 2022
Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git
added a commit
that referenced
this pull request
Aug 11, 2022
Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)