Use accessTokenExpiresIn to replace accessTokenExpireTime in tests #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send KVO notifications when authState updates tokens.
Uses bit mask to verify KVO notifications are sent.
…ogleSignIn-iOS into pin-AddKVOInGoogleUser
Since we use NSObject automatic change notifications we can remove the tests for manual notifications emission.
Added a new test case `testUpdateAuthStateWithUnchangedRefreshTokenAndIDToken `
Alex-4-Git
force-pushed
the
pin-ImproveAccessTokenExpireTime
branch
from
0c6682a to
6ec86da
Compare
petea
reviewed
Sep 26, 2022
petea
approved these changes
Sep 26, 2022
Use expiresIn on both access toke and id token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OIDTokenResponse requires a time interval to indicate the life time of the access token such as 3600.
In the current unit tests we first set the expiration time using
NSTimeInterval accessTokenExpireTime = [[NSDate date] timeIntervalSince1970] + accessExpireIn;Then when we need the time interval we do
NSNumber *accessTokenExpiresIn = @(accessTokenExpireTime - [[NSDate date] timeIntervalSince1970]);This PR is to simplify this by directly set the life time of accessToken
accessTokenExpiresIn.