Add Bridge.Onramp functions + port old functions #7076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes the behavior of buyWithCrypto to use the Universal Bridge service instead of the legacy API - Updates getQuote and getTransfer implementation to use Bridge.Buy and Bridge.Sell - Adds a new Transfer module to the Bridge namespace for token transfers - Removes the legacy API endpoints from definitions.ts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Adds new Transfer module for direct token transfers - Implements prepare function for getting transfer quotes and transactions - Adds tests for the Transfer module 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Switch useSendTransaction and useSwapSupportedChains to use Bridge.routes endpoint for retrieving supported destinations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Changed import from Bridge to Transfer for better clarity and consistency. - Updated the usage of the Transfer module in the getBuyWithCryptoTransfer function.
…b.com/thirdweb-dev/js into greg/tool-4506-update-routes-endpoint
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces documentation and assets for integrating thirdweb tools into the Stylus contract development workflow, specifically for Rust. It includes setup instructions, publishing and deployment commands, and images to enhance the documentation.
### Detailed summary
- Added new sections in `page.mdx` for Arbitrum Stylus.
- Included prerequisites for Rust and Solidity installations.
- Provided setup commands for creating a Stylus project.
- Added commands for publishing and deploying Stylus contracts.
- Included images (`stylus-publish-page.png`, `stylus-deploy-page.png`) to illustrate the process.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
Signed-off-by: samina <[email protected]>
Signed-off-by: Maximilian Hubert <[email protected]>
Signed-off-by: samina <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on updating the pricing plans and features for the embedded wallets in the dashboard application. It adjusts the plan requirements and modifies the features associated with different plans.
### Detailed summary
- Changed `authRequiredPlan` from `"accelerate"` to `"growth"`.
- Added `"Custom Wallet Branding & Auth"` to the features list.
- Removed `"Custom Wallet Branding & Auth"` from the `TEAM_PLANS` features.
- Increased `$400 Usage Credits` to `$500 Usage Credits` in the `TEAM_PLANS` features.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
gregfromstl
reviewed
May 19, 2025
| // onrampChainId: 1, // chain to initially onramp to | ||
| // currency: "USD", | ||
| // maxSteps: 2, | ||
| // purchaseData: { customId: "123" } |
There was a problem hiding this comment.
We should include an optional country param in case calling from the server
There was a problem hiding this comment.
btw i dont think the ip country detection works, its letting me see stripe stuff which is not available in NZ
There was a problem hiding this comment.
I don't think it does either and I don't know why
.changeset/tidy-seas-sing.md
Outdated
| }); | ||
|
|
||
| console.log(preparedOnramp.link); // URL to redirect the user to | ||
| console.log(preparedOnramp.destinationAmount); // Amount of token user will receive |
There was a problem hiding this comment.
Instead of destination amount (since they inputted that) I would highlight the currencyAmount, how much they'll pay
| @@ -16,7 +16,7 @@ Developers can turn on Test Mode to test both fiat-to-crypto transactions and cr | |||
|
|
|||
| ## Buy With Fiat | |||
|
|
|||
| By setting `testMode` to `true` for Buy With Fiat, you can enable test experiences for our underlying providers (Stripe, Kado, and Transak). | |||
| By setting `testMode` to `true` for Buy With Fiat, you can enable test experiences for our underlying providers (Coinbase, Stripe, and Transak). | |||
There was a problem hiding this comment.
This isn't true at the moment
There was a problem hiding this comment.
yeah, we'll have to fix that :D pretty important
| ); | ||
| return toBuyWithFiatStatus({ intentId: params.intentId, result }); | ||
| } catch (error) { | ||
| // If the session is not found, the Onramp.status endpoint will return a 404 which we map to |
There was a problem hiding this comment.
This should never happen since the onramps are stored on quote and if it does we should throw
There was a problem hiding this comment.
ok i wasn't sure. fixed
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR primarily focuses on enhancing the
Onrampfunctionality within thethirdweblibrary, including the addition of new features, updates to existing types, and the removal of deprecated components related to fiat transactions.Detailed summary
.tsxfiles related to fiat transaction screens.Bridge.Onramp.prepareandBridge.Onramp.statusfunctions for managing onramp transactions.priceUsdtoTokentype andBridgeActiontype for transaction actions.KADO.useOnRampStatus.