Skip to content

[Engine] Add FAILED status to execution result and update error handling #7065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 16, 2025


PR-Codex overview

This PR focuses on enhancing the transaction handling and status reporting in the thirdweb engine. It includes updates to transaction statuses, improvements in the airdrop and minting functionalities, and adjustments to the UI for better clarity.

Detailed summary

  • Updated title in page.tsx to "Mint Dynamic NFTs".
  • Modified transaction status handling to include createdAt, confirmedAt, and cancelledAt timestamps.
  • Changed contractAddress for airdrop and minting in constants files.
  • Improved error handling in transaction functions.
  • Enhanced airdrop and minting code examples for clarity.
  • Updated setQueueId to handle direct response objects instead of specific properties.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 10:18am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 10:18am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 10:18am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 10:18am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 10:18am

Copy link

changeset-bot bot commented May 16, 2025

⚠️ No Changeset found

Latest commit: 0984e46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review May 16, 2025 08:55
@joaquim-verges joaquim-verges requested review from a team as code owners May 16, 2025 08:55
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented May 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (-0.02% 🔽) 1.1 s (-0.02% 🔽) 191 ms (+193.32% 🔺) 1.3 s
thirdweb (cjs) 194.07 KB (+0.19% 🔺) 3.9 s (+0.19% 🔺) 344 ms (+29.46% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 70 ms (+894.86% 🔺) 184 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 21 ms (+1042.86% 🔺) 32 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 98 ms (+538.59% 🔺) 489 ms

Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.47%. Comparing base (e71e7d7) to head (08ed890).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/engine/get-status.ts 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7065      +/-   ##
==========================================
- Coverage   55.50%   55.47%   -0.03%     
==========================================
  Files         909      909              
  Lines       58402    58405       +3     
  Branches     4071     4067       -4     
==========================================
- Hits        32415    32400      -15     
- Misses      25882    25902      +20     
+ Partials      105      103       -2     
Flag Coverage Δ
packages 55.47% <0.00%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
packages/thirdweb/src/engine/get-status.ts 5.74% <0.00%> (-0.21%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 61152dd into main May 16, 2025
23 of 24 checks passed
@joaquim-verges joaquim-verges deleted the _Engine_Add_FAILED_status_to_execution_result_and_update_error_handling branch May 16, 2025 10:34
@joaquim-verges joaquim-verges mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant