Skip to content

[Engine] Add all testnets to test transaction options #7066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 16, 2025


PR-Codex overview

This PR updates the SendTestTransaction component to utilize a new hook, useAllChainsData, for fetching available chain data, replacing hardcoded chain IDs with dynamic data filtered based on specific criteria.

Detailed summary

  • Removed imports for specific chain IDs.
  • Added useAllChainsData hook to fetch all chains data.
  • Replaced hardcoded chainIds in SingleNetworkSelector with dynamic IDs from the chainsQuery.
  • Filtered chains to include only testnets that do not have a zksync_stack.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 16, 2025 10:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 16, 2025 10:12 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 16, 2025 10:12 Inactive
Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 10:37am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 16, 2025 10:37am
login ⬜️ Skipped (Inspect) May 16, 2025 10:37am
thirdweb_playground ⬜️ Skipped (Inspect) May 16, 2025 10:37am
wallet-ui ⬜️ Skipped (Inspect) May 16, 2025 10:37am

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 16, 2025 10:12 Inactive
Copy link

changeset-bot bot commented May 16, 2025

⚠️ No Changeset found

Latest commit: 51d6c67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 16, 2025
Copy link
Member Author

joaquim-verges commented May 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.50%. Comparing base (e71e7d7) to head (51d6c67).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7066   +/-   ##
=======================================
  Coverage   55.50%   55.50%           
=======================================
  Files         909      909           
  Lines       58402    58402           
  Branches     4071     4071           
=======================================
  Hits        32415    32415           
  Misses      25882    25882           
  Partials      105      105           
Flag Coverage Δ
packages 55.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 171 ms (+134.88% 🔺) 1.3 s
thirdweb (cjs) 193.71 KB (0%) 3.9 s (0%) 362 ms (+32.94% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 71 ms (+1621.99% 🔺) 185 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 40 ms (+2233.47% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 78 ms (+505.87% 🔺) 468 ms

@vercel vercel bot temporarily deployed to Preview – login May 16, 2025 10:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 16, 2025 10:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 16, 2025 10:30 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 16, 2025 10:30 Inactive
@joaquim-verges joaquim-verges changed the title [Engine] Add chain ID 13337 to test transaction options [Engine] Add all testnets to test transaction options May 16, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review May 16, 2025 11:08
@joaquim-verges joaquim-verges requested review from a team as code owners May 16, 2025 11:08
@joaquim-verges joaquim-verges merged commit 99a7cce into main May 16, 2025
27 checks passed
@joaquim-verges joaquim-verges deleted the _Engine_Add_chain_ID_13337_to_test_transaction_options branch May 16, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant