-
Notifications
You must be signed in to change notification settings - Fork 559
[SDK] Export prepareUserOp and add support for new wallets #7061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Export prepareUserOp and add support for new wallets #7061
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9b4b67c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
d0a5d76
to
9b4b67c
Compare
| "com.reown" | ||
| "com.reown.docs" | ||
| "com.reown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a duplicate entry for com.reown
in the WCSupportedWalletIds
type definition. It's listed on both line 411 and again on line 413. This duplication could potentially cause type conflicts or issues with wallet identification logic. One of these duplicate entries should be removed to maintain a clean type definition.
| "com.reown" | |
| "com.reown.docs" | |
| "com.reown" | |
+ | "com.reown" | |
+ | "com.reown.docs" |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| "com.reown" | ||
| "com.reown.docs" | ||
| "com.reown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a duplicate entry for com.reown
in the WCSupportedWalletIds
type definition. It's listed twice - once on line 411 and again on line 413. This duplication could potentially cause issues with type checking or wallet identification. One of these entries should be removed to maintain a clean type definition.
| "com.reown" | |
| "com.reown.docs" | |
| "com.reown" | |
+ | "com.reown" | |
+ | "com.reown.docs" |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7061 +/- ##
=======================================
Coverage 55.50% 55.50%
=======================================
Files 909 909
Lines 58402 58402
Branches 4070 4071 +1
=======================================
Hits 32415 32415
Misses 25882 25882
Partials 105 105
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR focuses on enhancing the
thirdweb
wallet library by adding new wallet entries, updating existing wallet information, and introducing a utility function for preparing user operations.Detailed summary
prepareUserOp
utility function topackages/thirdweb/src/wallets/smart/lib/userop.ts
.com.fastex.wallet
,com.socios.app
, and others.homepage
andimage_id
for various wallets.io.bimwallet
,com.adftechnology
, andai.purewallet
.packages/thirdweb/src/wallets/__generated__/wallet-ids.ts
from 403 to 413.