Skip to content

[SDK] Export prepareUserOp and add support for new wallets #7061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 15, 2025


PR-Codex overview

This PR focuses on enhancing the thirdweb wallet library by adding new wallet entries, updating existing wallet information, and introducing a utility function for preparing user operations.

Detailed summary

  • Added prepareUserOp utility function to packages/thirdweb/src/wallets/smart/lib/userop.ts.
  • Updated wallet information for multiple wallets, including com.fastex.wallet, com.socios.app, and others.
  • Changed homepage and image_id for various wallets.
  • Added new wallet entries, such as io.bimwallet, com.adftechnology, and ai.purewallet.
  • Updated the wallet ID count in packages/thirdweb/src/wallets/__generated__/wallet-ids.ts from 403 to 413.
  • Introduced images for new wallets in the generated wallet files.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:05pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:05pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:05pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:05pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:05pm

Copy link

changeset-bot bot commented May 15, 2025

🦋 Changeset detected

Latest commit: 9b4b67c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 15, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented May 15, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 2.9 s (+12.08% 🔺) 4 s
thirdweb (cjs) 193.71 KB (0%) 3.9 s (0%) 8.9 s (-1.5% 🔽) 12.7 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 1.4 s (+756.09% 🔺) 1.5 s
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 77 ms (+55.56% 🔺) 87 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 392 ms (-1.21% 🔽) 783 ms

@joaquim-verges joaquim-verges force-pushed the _SDK_Export_prepareUserOp_and_add_support_for_new_wallets branch from d0a5d76 to 9b4b67c Compare May 15, 2025 20:55
Comment on lines +411 to +413
| "com.reown"
| "com.reown.docs"
| "com.reown"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a duplicate entry for com.reown in the WCSupportedWalletIds type definition. It's listed on both line 411 and again on line 413. This duplication could potentially cause type conflicts or issues with wallet identification logic. One of these duplicate entries should be removed to maintain a clean type definition.

Suggested change
| "com.reown"
| "com.reown.docs"
| "com.reown"
+ | "com.reown"
+ | "com.reown.docs"

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +411 to +413
| "com.reown"
| "com.reown.docs"
| "com.reown"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a duplicate entry for com.reown in the WCSupportedWalletIds type definition. It's listed twice - once on line 411 and again on line 413. This duplication could potentially cause issues with type checking or wallet identification. One of these entries should be removed to maintain a clean type definition.

Suggested change
| "com.reown"
| "com.reown.docs"
| "com.reown"
+ | "com.reown"
+ | "com.reown.docs"

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.50%. Comparing base (ba52e68) to head (9b4b67c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7061   +/-   ##
=======================================
  Coverage   55.50%   55.50%           
=======================================
  Files         909      909           
  Lines       58402    58402           
  Branches     4070     4071    +1     
=======================================
  Hits        32415    32415           
  Misses      25882    25882           
  Partials      105      105           
Flag Coverage Δ
packages 55.50% <ø> (ø)
Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/smart/lib/userop.ts 77.66% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 8d47864 into main May 15, 2025
24 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_Export_prepareUserOp_and_add_support_for_new_wallets branch May 15, 2025 23:43
@joaquim-verges joaquim-verges mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant