-
Notifications
You must be signed in to change notification settings - Fork 559
[SDK] Fix buyWithCrypto false not respected when returning from quote #7069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix buyWithCrypto false not respected when returning from quote #7069
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: f259dc5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7069 +/- ##
==========================================
+ Coverage 55.47% 55.49% +0.02%
==========================================
Files 909 909
Lines 58405 58406 +1
Branches 4067 4075 +8
==========================================
+ Hits 32400 32415 +15
+ Misses 25902 25886 -16
- Partials 103 105 +2
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR addresses an issue where the
buyWithCrypto
option was not being respected when navigating back from the quote screen. It ensures that the correct payment method is enabled based on the current screen.Detailed summary
onBack
function to check ifenabledPaymentMethods.buyWithCryptoEnabled
is true.screen.id
checks forbuy-with-crypto
andbuy-with-fiat
are properly combined with the new condition.