Skip to content

[Dashboard] Add pagination to server wallets page #7070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 16, 2025


PR-Codex overview

This PR introduces pagination functionality to the ServerWalletsTableUI component, enhancing the user interface for displaying server wallets. It adds support for current page tracking, total records, and total pages, allowing users to navigate through wallet entries more effectively.

Detailed summary

  • Added currentPage, totalPages, and totalRecords to the props of ServerWalletsTableUI.
  • Updated TransactionsServerWalletsPage to handle searchParams for page tracking.
  • Implemented pagination logic in ServerWalletsTableUI for navigating wallet entries.
  • Displayed total records and pagination controls in the UI.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 0:02am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 16, 2025 0:02am
login ⬜️ Skipped (Inspect) May 16, 2025 0:02am
thirdweb_playground ⬜️ Skipped (Inspect) May 16, 2025 0:02am
wallet-ui ⬜️ Skipped (Inspect) May 16, 2025 0:02am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 16, 2025 11:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 16, 2025 11:30 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 16, 2025 11:30 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 16, 2025 11:30 Inactive
Copy link

changeset-bot bot commented May 16, 2025

⚠️ No Changeset found

Latest commit: d06c580

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 16, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review May 16, 2025 11:31
@joaquim-verges joaquim-verges requested review from a team as code owners May 16, 2025 11:31
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.47%. Comparing base (e62fd3f) to head (d06c580).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7070   +/-   ##
=======================================
  Coverage   55.47%   55.47%           
=======================================
  Files         909      909           
  Lines       58405    58405           
  Branches     4067     4067           
=======================================
  Hits        32400    32400           
  Misses      25902    25902           
  Partials      103      103           
Flag Coverage Δ
packages 55.47% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 184 ms (+61.66% 🔺) 1.3 s
thirdweb (cjs) 194.07 KB (0%) 3.9 s (0%) 419 ms (+5.51% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 31 ms (+289.05% 🔺) 144 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 19 ms (+376.33% 🔺) 30 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 26 ms (+12.57% 🔺) 416 ms

@joaquim-verges joaquim-verges force-pushed the _Dashboard_Add_pagination_to_server_wallets_page branch from ac185d9 to d06c580 Compare May 16, 2025 11:55
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 16, 2025 11:55 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 16, 2025 11:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 16, 2025 11:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 16, 2025 11:55 Inactive
@@ -30,17 +32,23 @@ export default async function TransactionsServerWalletsPage(props: {
const managementAccessToken =
projectEngineCloudService?.managementAccessToken;

const pageSize = 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a discrepancy between the pageSize value set to 10 in the implementation and the value of 20 mentioned in the PR description. For consistency, consider updating this value to match what was documented in the PR description.

Suggested change
const pageSize = 10;
const pageSize = 20;

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@joaquim-verges joaquim-verges merged commit 170f14f into main May 16, 2025
24 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Add_pagination_to_server_wallets_page branch May 16, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant