-
Notifications
You must be signed in to change notification settings - Fork 560
[Dashboard] Add pagination to server wallets page #7070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Add pagination to server wallets page #7070
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7070 +/- ##
=======================================
Coverage 55.47% 55.47%
=======================================
Files 909 909
Lines 58405 58405
Branches 4067 4067
=======================================
Hits 32400 32400
Misses 25902 25902
Partials 103 103
🚀 New features to boost your workflow:
|
size-limit report 📦
|
ac185d9
to
d06c580
Compare
@@ -30,17 +32,23 @@ export default async function TransactionsServerWalletsPage(props: { | |||
const managementAccessToken = | |||
projectEngineCloudService?.managementAccessToken; | |||
|
|||
const pageSize = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a discrepancy between the pageSize
value set to 10
in the implementation and the value of 20
mentioned in the PR description. For consistency, consider updating this value to match what was documented in the PR description.
const pageSize = 10; | |
const pageSize = 20; |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
PR-Codex overview
This PR introduces pagination functionality to the
ServerWalletsTableUI
component, enhancing the user interface for displaying server wallets. It adds support for current page tracking, total records, and total pages, allowing users to navigate through wallet entries more effectively.Detailed summary
currentPage
,totalPages
, andtotalRecords
to the props ofServerWalletsTableUI
.TransactionsServerWalletsPage
to handlesearchParams
for page tracking.ServerWalletsTableUI
for navigating wallet entries.