-
Notifications
You must be signed in to change notification settings - Fork 557
[Vault] default to engine-cloud vault proxy #7058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: da8dff0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7058 +/- ##
=======================================
Coverage 55.50% 55.50%
=======================================
Files 909 909
Lines 58402 58402
Branches 4070 4070
=======================================
Hits 32415 32415
Misses 25882 25882
Partials 105 105
🚀 New features to boost your workflow:
|
size-limit report 📦
|
PR-Codex overview
This PR introduces enhancements to the
createVaultClient
function in thevault-sdk
package by adding support for an optionalsecretKey
and updating the defaultbaseUrl
. It also modifies the request headers to include thesecretKey
when provided.Detailed summary
createVaultClient
function to accept an optionalsecretKey
.baseUrl
to "https://engine.thirdweb.com" if not provided.x-secret-key
ifsecretKey
is supplied.