Skip to content

[Vault] default to engine-cloud vault proxy #7058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented May 15, 2025

PR-Codex overview

This PR introduces enhancements to the createVaultClient function in the vault-sdk package by adding support for an optional secretKey and updating the default baseUrl. It also modifies the request headers to include the secretKey when provided.

Detailed summary

  • Updated createVaultClient function to accept an optional secretKey.
  • Set default baseUrl to "https://engine.thirdweb.com" if not provided.
  • Constructed headers to include x-secret-key if secretKey is supplied.
  • Simplified the headers assignment in the fetch request.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 15, 2025

🦋 Changeset detected

Latest commit: da8dff0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/vault-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:00pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:00pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:00pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:00pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 9:00pm

Copy link
Contributor

graphite-app bot commented May 15, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.50%. Comparing base (0eff648) to head (da8dff0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7058   +/-   ##
=======================================
  Coverage   55.50%   55.50%           
=======================================
  Files         909      909           
  Lines       58402    58402           
  Branches     4070     4070           
=======================================
  Hits        32415    32415           
  Misses      25882    25882           
  Partials      105      105           
Flag Coverage Δ
packages 55.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 15, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 196 ms (+162.67% 🔺) 1.3 s
thirdweb (cjs) 193.71 KB (0%) 3.9 s (0%) 402 ms (+54.79% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 50 ms (+750.64% 🔺) 164 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 16 ms (+939.64% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 53 ms (+337.39% 🔺) 444 ms

@joaquim-verges joaquim-verges changed the title default to engine-cloud vault proxy [Vault] default to engine-cloud vault proxy May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants