Skip to content

[Dashboard] Remove taint for THIRDWEB_ENGINE_URL #7074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 17, 2025


PR-Codex overview

This PR removes a conditional block that was checking if the THIRDWEB_ENGINE_URL is set, along with a call to experimental_taintUniqueValue. This change simplifies the handling of the THIRDWEB_ENGINE_URL constant.

Detailed summary

  • Removed the conditional check for THIRDWEB_ENGINE_URL.
  • Deleted the call to experimental_taintUniqueValue related to THIRDWEB_ENGINE_URL.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2025 7:52am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 17, 2025 7:52am
login ⬜️ Skipped (Inspect) May 17, 2025 7:52am
thirdweb_playground ⬜️ Skipped (Inspect) May 17, 2025 7:52am
wallet-ui ⬜️ Skipped (Inspect) May 17, 2025 7:52am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 17, 2025 07:45 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 17, 2025 07:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 17, 2025 07:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 17, 2025 07:45 Inactive
Copy link

changeset-bot bot commented May 17, 2025

⚠️ No Changeset found

Latest commit: 293c135

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 17, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review May 17, 2025 07:46
@joaquim-verges joaquim-verges requested review from a team as code owners May 17, 2025 07:46
Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.49%. Comparing base (0c853e8) to head (293c135).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7074   +/-   ##
=======================================
  Coverage   55.49%   55.49%           
=======================================
  Files         909      909           
  Lines       58406    58406           
  Branches     4072     4072           
=======================================
  Hits        32415    32415           
  Misses      25886    25886           
  Partials      105      105           
Flag Coverage Δ
packages 55.49% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 320 ms (+79.33% 🔺) 1.5 s
thirdweb (cjs) 194.07 KB (0%) 3.9 s (0%) 729 ms (+8.18% 🔺) 4.7 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 54 ms (+247.58% 🔺) 168 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 27 ms (+529.84% 🔺) 37 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 38 ms (+28.84% 🔺) 429 ms

@joaquim-verges joaquim-verges merged commit fdd3441 into main May 17, 2025
25 of 26 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Remove_taint_for_THIRDWEB_ENGINE_URL branch May 17, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant