Kube2iam docs #295

MattiasGees · 2018-06-08T09:29:50Z

What this PR does / why we need it:
Docs on how to add kube2iam to our Tarmak setup

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #290

Special notes for your reviewer:
We also need #293 merged for checks to clear

Release note:

NONE

MattiasGees · 2018-06-11T15:22:27Z

/retest

MattiasGees · 2018-06-12T10:37:58Z

/assign @dippynark

dippynark · 2018-06-19T13:42:36Z

docs/examples/kube2iam.rst

+Prerequisite
+~~~~~~~~~~~~
+
+Make sure `HELM <https://www.helm.sh/>`_ is `activated <https://docs.tarmak.io/user-guide.html#tiller>` on the Tarmak cluster.


link isn't displaying properly

Possibly refer to the tarmak docs for installing tiller into the cluster too rather than suggesting using helm init

@dippynark link is fixed and it was already linked to the docs of tarmak to setup helm.

dippynark · 2018-06-19T13:53:31Z

docs/examples/kube2iam.rst

+
+.. code-block:: bash
+
+    helm version


how can I connect to tarmak using helm? The process of retrieving a kubeconfig is not clear here - I had to hack the kubeconfig generated by tarmak kubectl get nodes and exposed the LB publically

that will be part of #279. I will make sure to add an reference in these docs once that will be done.

dippynark · 2018-06-19T14:02:44Z

docs/examples/kube2iam.rst

+
+.. code-block:: bash
+
+    helm upgrade kube2iam stable/kube2iam \


This chart doesn't exist yet?

that chart exists https://github.com/kubernetes/charts/tree/master/stable/kube2iam

dippynark · 2018-06-19T16:37:57Z

docs/examples/kube2iam.rst

+    }
+
+    variable "instance_iam_role_arn" {
+        description = "ARN of the instance IAM role


$ terraform init There are some problems with the configuration, described below. The Terraform configuration must be valid before initialization so that Terraform can determine which modules and providers need to be installed. Error: Error parsing /Users/luke/Desktop/nginx/test.tf: At 19:48: literal not terminated

dippynark · 2018-06-19T16:40:28Z

docs/examples/kube2iam.rst

+.. code-block:: bash
+
+    terraform init
+    terraform apply -var cluster_name=example -var region=eu-west-1 -var instance_arn=arn:aws:iam::xxxxxxx:role/my-instance-role


$ terraform apply -var cluster_name=cluster -var region=eu-west-1 -var instance_arn=arn:aws:iam::015774327972:policy/kube2iam_assumeRole_policy_cluster var.instance_iam_role_arn ARN of the instance IAM role Enter a value:

dippynark · 2018-06-19T16:41:47Z

docs/examples/kube2iam.rst

+            "Action": "sts:AssumeRole",
+            "Principal": {
+            "AWS": [
+                "${instance_iam_role_arn}"


var.instance_iam_role_arn?

dippynark · 2018-06-19T16:42:25Z

docs/examples/kube2iam.rst

+        EOF
+    }
+
+    resource "aws_iam_role_policy" "test_role_policy" {


$ terraform apply -var cluster_name=cluster -var region=eu-west-1 -var instance_iam_role_arn=arn:aws:iam::015774327972:policy/kube2iam_assumeRole_policy_cluster Error: aws_iam_role_policy.test_role_policy: "policy" contains an invalid JSON policy

MattiasGees · 2018-06-19T18:46:27Z

@dippynark I addressed all comments.

dippynark · 2018-06-21T11:22:24Z

/lgtm

MattiasGees · 2018-06-21T11:30:45Z

Thx @dippynark for getting through this PR with me. I know this was a painfull process :)

dippynark · 2018-06-27T10:03:30Z

/unassign

MattiasGees · 2018-06-28T07:25:19Z

Fixed merge conflicts
/unassign
/assign @dippynark

charlieegan3 · 2018-07-03T09:24:17Z

I've taken a read over this. I've not tried it all out but it makes sense to me.

/lgtm

charlieegan3 · 2018-07-03T09:29:16Z

/assign @simonswine

charlieegan3 · 2018-07-03T09:29:37Z

/unassign

simonswine · 2018-07-09T11:12:42Z

/approve

jetstack-bot · 2018-07-09T11:12:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [simonswine]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…101-#287-#288-#293-#285-#299-#301-#304-#267-#305-#306-#326-#323-#322-#327-#330-#329-#346-#338-#313-#300-#296-#347-#295-#344-#235-#361-#365-#345-#343-#325-#336-#321-#371-#364-#378-origin-release-0.4 Automated cherry pick of #247 #101 #287 #288 #293 #285 #299 #301 #304 #267 #305 #306 #326 #323 #322 #327 #330 #329 #346 #338 #313 #300 #296 #347 #295 #344 #235 #361 #365 #345 #343 #325 #336 #321 #371 #364 #378

Start of kube2iam docs

cc305fe

jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2018

jetstack-bot requested a review from JoshVanL June 8, 2018 09:30

MattiasGees added 8 commits June 8, 2018 11:31

Add examples to index

f9c8186

Spelling fixes

2dc95d8

For some reason it doesn't like add-ons :(

60fa0f8

Remove anchor

bde22af

Change to yaml

f0750b9

Change to none

40bd0ea

Extend docs of kube2iam

2ebcd58

Fix spelling

0e21150

jetstack-bot assigned dippynark Jun 12, 2018

MattiasGees added 2 commits June 12, 2018 14:14

Add prerequisite

887e548

Remove enter

ec6fa7c

MattiasGees changed the title ~~Start of kube2iam docs~~ Kube2iam docs Jun 14, 2018

jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2018

Merge branch 'master' into kube2iam-docs

dcf9df0

jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2018

Finish docs

3d3bc1f

dippynark reviewed Jun 19, 2018

View reviewed changes

MattiasGees added 2 commits June 19, 2018 15:16

Fix link

be418dc

Fix chart version

6d98a4e

dippynark reviewed Jun 19, 2018

View reviewed changes

MattiasGees added 2 commits June 19, 2018 19:44

TF fixes in docs

1e56b37

Fix terraform apply

1bffaee

jetstack-bot assigned MattiasGees and unassigned dippynark Jun 21, 2018

jetstack-bot assigned dippynark Jun 21, 2018

jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2018

jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2018

jetstack-bot unassigned dippynark Jun 27, 2018

Merge remote-tracking branch 'upstream/master' into kube2iam-docs

70bc5b2

jetstack-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 28, 2018

jetstack-bot assigned dippynark and unassigned MattiasGees Jun 28, 2018

jetstack-bot assigned charlieegan3 Jul 3, 2018

jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2018

jetstack-bot assigned simonswine Jul 3, 2018

jetstack-bot unassigned charlieegan3 Jul 3, 2018

simonswine unassigned dippynark Jul 9, 2018

jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2018

simonswine merged commit 39ac5fa into jetstack:master Jul 9, 2018

MattiasGees deleted the kube2iam-docs branch July 9, 2018 15:01

dippynark mentioned this pull request Jul 25, 2018

Automated cherry pick of #247 #101 #287 #288 #293 #285 #299 #301 #304 #267 #305 #306 #326 #323 #322 #327 #330 #329 #346 #338 #313 #300 #296 #347 #295 #344 #235 #361 #365 #345 #343 #325 #336 #321 #371 #364 #378 #381

Merged

Kube2iam docs #295

Kube2iam docs #295

Uh oh!

Conversation

MattiasGees commented Jun 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MattiasGees commented Jun 11, 2018

Uh oh!

MattiasGees commented Jun 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dippynark Jun 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MattiasGees commented Jun 19, 2018

Uh oh!

dippynark commented Jun 21, 2018

Uh oh!

MattiasGees commented Jun 21, 2018

Uh oh!

dippynark commented Jun 27, 2018

Uh oh!

MattiasGees commented Jun 28, 2018

Uh oh!

charlieegan3 commented Jul 3, 2018

Uh oh!

charlieegan3 commented Jul 3, 2018

Uh oh!

charlieegan3 commented Jul 3, 2018

Uh oh!

simonswine commented Jul 9, 2018

Uh oh!

jetstack-bot commented Jul 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MattiasGees commented Jun 8, 2018 •

edited

Loading

dippynark Jun 19, 2018 •

edited

Loading