Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Conversation

@dippynark
Copy link
Contributor

@dippynark dippynark commented Jul 25, 2018

Cherry pick of #247 #101 #287 #288 #293 #285 #299 #301 #304 #267 #305 #306 #326 #323 #322 #327 #330 #329 #346 #338 #313 #300 #296 #347 #295 #344 #235 #361 #365 #345 #343 #325 #336 #321 #371 #364 #378 on release-0.4.

#247: Write ssh config at tarmak initialisation to ensue
#101: Deal with dynamic number of public subnets
#287: Add binary compression to the release builds
#288: Remove -N flag as we are not running a remote command and
#293: Add docs for additional IAM policies
#285: Refactor validate and verify
#299: Upgrade centos to the latest version 7.3
#301: Fix docker slice drop-in by changing quoting and file type
#304: Fix stateful instance naming
#267: Add addon documentation
#305: Upgrade sphinx and base image
#306: Cluster and instance pool should within IAM additional
#326: Fix config parsing
#323: Update terraform to 0.11.7
#322: Pass through etcd instance pool min count to puppet
#327: Add basic docs about apiserver
#330: Fix duplicate ELB name error
#329: Remove unneeded input for Jenkins instance size
#346: Use latest versions of CA
#338: Add security group to allow cluster autoscaler scraping
#313: Fix etcd mount race
#300: Change cgroup drive to cgroupfs
#296: Increase kubelet resource reservations
#347: Adds validation check to ensure instance types in
#295: Start of kube2iam docs
#344: Adds hub remote state verification for multi-clusters
#235: Implements vault-helper dry run and ensure on new tarmak
#361: Use bastion and vault instance type from config
#365: Scrape controller-managers and schedulers
#345: Upgrade Tiller puppet module and docs
#343: Upgrade Dashboard and add RBAC support
#325: Autoscaling arbitrary worker pools
#336: Remove internal worker ELB
#321: Remove Jenkins volume from state module
#371: Revert "vault-helper dry run and delete"
#364: Update vault-helper to 0.9.13
#378: Prepare hub before terraforming other clusters

cherry-pick fixes to 0.4 release

JoshVanL and others added 30 commits July 25, 2018 17:10
Otherwise it writes the config whenever we create a new tarmak instance
Make sure that validate and verify are present on cluster, environment and provider. This streamlines the use of both validate and verify as central calling point instead of all different methods.
@jetstack-bot jetstack-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 25, 2018
@munnerz
Copy link
Contributor

munnerz commented Jul 25, 2018

Is this just fast-forwarding release-0.4 to HEAD? If so, you should just do a git merge --ff-only or whatever it is, which will update release-0.4 to the head of master.

Otherwise, if there are changes in master that you don't want in release-0.4, this does make sense.

Ideally in future, we should probably cut release branches from master, until e.g. 0.4.0 is cut - at which point we'd switch to cherry picking in patches (which then make it into 0.4.1, etc)

/cc @simonswine

@jetstack-bot jetstack-bot requested a review from simonswine July 25, 2018 17:27
@simonswine
Copy link
Contributor

@munnerz that are all bugfixes only, 0.4.0 was meant to be cut after the rc1, but then priorities shifted. @mattbates wants us to release a 0.4.0 with fixed bugs so here we are...

The master will become 0.5.0 including features that are important

@dippynark
Copy link
Contributor Author

/test puppet-kubernetes-acceptance

@dippynark
Copy link
Contributor Author

/test puppet-vault_client-acceptance-centos

1 similar comment
@dippynark
Copy link
Contributor Author

/test puppet-vault_client-acceptance-centos

@dippynark
Copy link
Contributor Author

/test puppet-etcd-acceptance-single-node

@dippynark
Copy link
Contributor Author

/test puppet-tarmak-acceptance-ubuntu v1.9

@dippynark
Copy link
Contributor Author

/test puppet-tarmak-acceptance-centos v1.9

@dippynark
Copy link
Contributor Author

/test puppet-vault_client-acceptance-ubuntu

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 26, 2018
@simonswine
Copy link
Contributor

I have tested it on a single environment. All looking good IMHO

@dippynark let me know how your multi cluster went and assign it to me

@dippynark
Copy link
Contributor Author

@simonswine yeah everything green
/assign @simonswine

@dippynark
Copy link
Contributor Author

/unassign

@simonswine
Copy link
Contributor

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2018
@jetstack-bot jetstack-bot merged commit 7785524 into jetstack:release-0.4 Jul 27, 2018
@jetstack-bot
Copy link
Collaborator

jetstack-bot commented Jul 27, 2018

@dippynark: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-etcd-acceptance-single-node 31bf33c link /test puppet-etcd-acceptance-single-node
tarmak-puppet-module-tarmak-acceptance-1-9-centos 31bf33c link /test puppet-tarmak-acceptance-centos v1.9
tarmak-puppet-module-fluent_bit-acceptance 31bf33c link /test puppet-fluent_bit-acceptance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants