This repository was archived by the owner on Jan 9, 2023. It is now read-only.
Improve vault tunnel creation #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
the
release-note
jetstack-bot
added
the
size/S
dippynark
force-pushed
the
fix-vault-tunnel-creation
branch
2 times, most recently
from
41c8ef6 to
439057b
Compare
…ing when creating Vault tunnels
dippynark
force-pushed
the
fix-vault-tunnel-creation
branch
from
439057b to
50183e9
Compare
simonswine
reviewed
Jun 5, 2018
pkg/tarmak/vault/vault.go
Outdated
| return | ||
| } | ||
|
|
||
| if health.Standby == false && health.Sealed == false { |
Contributor
There was a problem hiding this comment.
Maybe we have to check here for health.Initialized
pkg/tarmak/vault/vault.go
Outdated
| VaultStateUnsealed | ||
| VaultStateUnintialised | ||
| VaultStateErr | ||
| vaultTunnelCreationTimeoutSeconds = 5 |
Contributor
There was a problem hiding this comment.
Please test multi/single cluster E2E, I am not too sure if that is a good value
Contributor
Author
There was a problem hiding this comment.
It worked fine with 5, but have upped it to 10 to be safe
Contributor
|
/assign @dippynark @dippynark what is your feeling about my comments? |
dippynark
force-pushed
the
fix-vault-tunnel-creation
branch
from
42032bf to
d0a470b
Compare
Contributor
|
Thanks luke for tracking this down /lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonswine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
jetstack-bot
added a commit
that referenced
this pull request
Jul 27, 2018
…101-#287-#288-#293-#285-#299-#301-#304-#267-#305-#306-#326-#323-#322-#327-#330-#329-#346-#338-#313-#300-#296-#347-#295-#344-#235-#361-#365-#345-#343-#325-#336-#321-#371-#364-#378-origin-release-0.4 Automated cherry pick of #247 #101 #287 #288 #293 #285 #299 #301 #304 #267 #305 #306 #326 #323 #322 #327 #330 #329 #346 #338 #313 #300 #296 #347 #295 #344 #235 #361 #365 #345 #343 #325 #336 #321 #371 #364 #378
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following:
-Nflag, which shouldn't be used as we are running a remote command (/bin/true)