This repository was archived by the owner on Jan 9, 2023. It is now read-only.
Upgrade Dashboard and add RBAC support #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
the
release-note
jetstack-bot
added
the
size/L
dippynark
force-pushed
the
341-upgrade-dashboard
branch
7 times, most recently
from
040d790 to
6556813
Compare
Contributor
Author
|
/retest |
dippynark
force-pushed
the
341-upgrade-dashboard
branch
from
6556813 to
a6a5721
Compare
Contributor
Author
|
/assign @simonswine |
dippynark
force-pushed
the
341-upgrade-dashboard
branch
2 times, most recently
from
64f1687 to
f96f835
Compare
dippynark
force-pushed
the
341-upgrade-dashboard
branch
from
f96f835 to
39d1428
Compare
simonswine
suggested changes
Jun 27, 2018
| $_image = 'gcr.io/google_containers/kubernetes-dashboard-amd64' | ||
| } else { | ||
| $_image = $image | ||
| } |
Contributor
There was a problem hiding this comment.
Please keep that in the parameters
| version based on the version of your Kubernetes cluster. The configuration block | ||
| accepts two optional fields of `image` and `version` allowing you to change | ||
| these defaults. Note that the final image tag used when deploying Tiller will be | ||
| the configured version prepended with the letter `v`. |
Contributor
There was a problem hiding this comment.
Can we have some warning about the security implications of the dashboard
Contributor
|
/assign @dippynark |
dippynark
force-pushed
the
341-upgrade-dashboard
branch
3 times, most recently
from
df35337 to
55e606c
Compare
Contributor
Author
|
/assign @simonswine |
dippynark
force-pushed
the
341-upgrade-dashboard
branch
from
55e606c to
71b2487
Compare
dippynark
force-pushed
the
341-upgrade-dashboard
branch
from
71b2487 to
7ef6af9
Compare
Contributor
|
/approve |
simonswine
approved these changes
Jul 12, 2018
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonswine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Contributor
|
/retest |
Contributor
|
/test puppet-tarmak-acceptance-ubuntu v1.9 |
jetstack-bot
added a commit
that referenced
this pull request
Jul 27, 2018
…101-#287-#288-#293-#285-#299-#301-#304-#267-#305-#306-#326-#323-#322-#327-#330-#329-#346-#338-#313-#300-#296-#347-#295-#344-#235-#361-#365-#345-#343-#325-#336-#321-#371-#364-#378-origin-release-0.4 Automated cherry pick of #247 #101 #287 #288 #293 #285 #299 #301 #304 #267 #305 #306 #326 #323 #322 #327 #330 #329 #346 #338 #313 #300 #296 #347 #295 #344 #235 #361 #365 #345 #343 #325 #336 #321 #371 #364 #378
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Upgrades Dashboard and adds RBAC support
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #341