Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Upgrade Tiller puppet module and docs #345

Merged
jetstack-bot merged 3 commits into from
Jul 13, 2018
Merged

Upgrade Tiller puppet module and docs #345

jetstack-bot merged 3 commits into from
Jul 13, 2018

Conversation

@dippynark
Copy link
Contributor

@dippynark dippynark commented Jun 23, 2018 •
edited
Loading

What this PR does / why we need it: Upgrade the Tiller puppet module and docs

Upgrade Tiller manifest versions and documentation

@jetstack-bot jetstack-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 23, 2018
@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2018
@dippynark
Copy link
Contributor Author

dippynark commented Jun 23, 2018

/assign @MattiasGees

@MattiasGees
Copy link
Member

MattiasGees commented Jun 25, 2018 •
edited
Loading

Tested this and all working

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2018
simonswine
simonswine previously requested changes Jun 26, 2018
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks see my comments

/assign @dippynark
/unassign

puppet/modules/kubernetes_addons/manifests/tiller.pp Outdated
$_version = '2.9.1'
} else {
$_version = $version
}
Copy link
Contributor

@simonswine simonswine Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you not keep it as a parameter default?

puppet/modules/kubernetes_addons/manifests/tiller.pp Outdated
$_image = 'gcr.io/kubernetes-helm/tiller'
} else {
$_image = $image
}
Copy link
Contributor

@simonswine simonswine Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you not keep it as a parameter default

docs/user-guide.rst
kubernetes:
tiller:
enabled: true
version: 2.9.1
Copy link
Contributor

@simonswine simonswine Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please keep that example how to change the version/tag of tiller

@simonswine
Copy link
Contributor

simonswine commented Jun 26, 2018

And also some better release-notes would have been great

@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2018
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 10, 2018
@dippynark
Copy link
Contributor Author

dippynark commented Jul 10, 2018

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned dippynark Jul 10, 2018
@simonswine
Copy link
Contributor

simonswine commented Jul 12, 2018

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2018
@jetstack-bot
Copy link
Collaborator

jetstack-bot commented Jul 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2018
@munnerz munnerz closed this Jul 13, 2018
@munnerz munnerz reopened this Jul 13, 2018
@jetstack-bot jetstack-bot merged commit 85e634f into jetstack:master Jul 13, 2018
@dippynark dippynark mentioned this pull request Jul 25, 2018
Merged
jetstack-bot added a commit that referenced this pull request Jul 27, 2018
@jetstack-bot
Merge pull request #381 from dippynark/automated-cherry-pick-of-#247-#…
7785524 
…101-#287-#288-#293-#285-#299-#301-#304-#267-#305-#306-#326-#323-#322-#327-#330-#329-#346-#338-#313-#300-#296-#347-#295-#344-#235-#361-#365-#345-#343-#325-#336-#321-#371-#364-#378-origin-release-0.4

Automated cherry pick of #247 #101 #287 #288 #293 #285 #299 #301 #304 #267 #305 #306 #326 #323 #322 #327 #330 #329 #346 #338 #313 #300 #296 #347 #295 #344 #235 #361 #365 #345 #343 #325 #336 #321 #371 #364 #378
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@charlieegan3 charlieegan3 Awaiting requested review from charlieegan3

1 more reviewer

@simonswine simonswine simonswine left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@simonswine simonswine

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dippynark @MattiasGees @simonswine @jetstack-bot @munnerz