This repository was archived by the owner on Jan 9, 2023. It is now read-only.
Fix etcd mount race condition #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
release-note
Contributor
Author
|
/retest |
Contributor
Author
|
/test puppet-tarmak-acceptance-centos v1.9 |
1 similar comment
Contributor
Author
|
/test puppet-tarmak-acceptance-centos v1.9 |
Contributor
Author
|
/test puppet-etcd-acceptance-single-node |
1 similar comment
Contributor
Author
|
/test puppet-etcd-acceptance-single-node |
Contributor
Author
|
/test puppet-tarmak-acceptance-centos v1.9 |
Contributor
Author
|
/test puppet-etcd-acceptance-single-node |
dippynark
force-pushed
the
fix-etcd-mount-race
branch
from
27e9c28 to
304f583
Compare
jetstack-bot
added
size/S
dippynark
force-pushed
the
fix-etcd-mount-race
branch
4 times, most recently
from
955da2f to
eefa387
Compare
jetstack-bot
added
size/XS
dippynark
force-pushed
the
fix-etcd-mount-race
branch
from
eefa387 to
1122cc9
Compare
jetstack-bot
added
size/S
dippynark
force-pushed
the
fix-etcd-mount-race
branch
from
1122cc9 to
3d99073
Compare
Contributor
Author
|
/assign @simonswine |
Contributor
Author
|
/unassign @simonswine |
Contributor
Author
|
/test puppet-tarmak-acceptance-centos v1.9 |
dippynark
force-pushed
the
fix-etcd-mount-race
branch
2 times, most recently
from
073e109 to
eea02ca
Compare
dippynark
force-pushed
the
fix-etcd-mount-race
branch
from
58cb74b to
16afff2
Compare
Contributor
Author
|
/unassign @dippynark |
Contributor
Author
|
/assign @simonswine |
Contributor
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
Author
|
/test puppet-etcd-acceptance-three-node |
dippynark
force-pushed
the
fix-etcd-mount-race
branch
7 times, most recently
from
fbf3f84 to
cbe9211
Compare
Contributor
Author
|
/retest |
dippynark
force-pushed
the
fix-etcd-mount-race
branch
from
cbe9211 to
52ae61f
Compare
dippynark
force-pushed
the
fix-etcd-mount-race
branch
from
52ae61f to
6e77d01
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonswine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
jetstack-bot
added a commit
that referenced
this pull request
Jul 27, 2018
…101-#287-#288-#293-#285-#299-#301-#304-#267-#305-#306-#326-#323-#322-#327-#330-#329-#346-#338-#313-#300-#296-#347-#295-#344-#235-#361-#365-#345-#343-#325-#336-#321-#371-#364-#378-origin-release-0.4 Automated cherry pick of #247 #101 #287 #288 #293 #285 #299 #301 #304 #267 #305 #306 #326 #323 #322 #327 #330 #329 #346 #338 #313 #300 #296 #347 #295 #344 #235 #361 #365 #345 #343 #325 #336 #321 #371 #364 #378
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: etcd service units do not wait until dependent volume has been formatted and mounted - this can lead to a race condition and missing data when starting/restarting etcd