Skip to content

Conversation

@htippanaboya
Copy link
Contributor

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

VeryEarly and others added 30 commits June 9, 2022 09:33
Co-authored-by: azure-powershell-bot <[email protected]>
* check if db created by log replay before dropping it

* Add test

* Bump err string

* Bump changelog
* Create using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md
* Fix Az.Aks Xml comments

* Fix Az.Aks Xml comments
* Fix Az.Blueprint XML Comments

* Fix Az.Blueprint XML Comments
* Move ConnectedMachine to main

* Update Changelog.md

Co-authored-by: azure-powershell-bot <[email protected]>
* Supported accepting rotation policy in a JSON file

* suppress breaking change issues

* upgrade Azure.Security.KeyVault.Keys to 4.3.0
* Add SqlTestRunner to replace SqlTestsBase

* Add SqlTestRunner to replace SqlTestsBase

* Add SqlTestRunner to replace SqlTestsBase

* Update SqlTestRunner.cs
* Fix Az.CosmosDB XML Comments

* Fix Az.CosmosDB XML Comments

* Update PSClientEncryptionPolicy.cs

Co-authored-by: Ziyue Zheng <[email protected]>
* Fix Az.Automation XML Comments

* Fix Az.Automation XML Comments

* Update SourceControlSyncJobStream.cs

Co-authored-by: Ziyue Zheng <[email protected]>
* Fix Az.Compute XML Comments

* Fix Az.Compute.Helpers XML Comments
* Fix Az.DataLakeStore XML Comments

* Fix Az.DataLakeStore XML Comments

Co-authored-by: Ziyue Zheng <[email protected]>
* Fix Az.EventHub XML Comments

* Update PSNetworkRuleSetAttributes.cs

Co-authored-by: Ziyue Zheng <[email protected]>
* Fix Az.IotHub XML Comments

* Fix Az.IotHub XML Comments

Co-authored-by: Ziyue Zheng <[email protected]>
…containers with Client Encryption Policy (#18480)

* Support client encryption policy during container creation

* Update SqlOperationsTests.ps1

* Update New-AzCosmosDBSqlContainer.md

* Update PSClientEncryptionPolicy.cs

* Update NewAzCosmosDBSqlContainer.cs

* Update ChangeLog.md

* Updated package.

* Update CosmosDB.Test.csproj

* Updated example, session records.

* updated session records.

* Fixes update container command on containers with client encryption policy.

* Update ChangeLog.md

* Update ChangeLog.md
* Pass Tags field in the Database model constructor

* Update change log
* Remove WebsitesController

* Update WebsitesTestRunner.cs

* Update WebsitesTestRunner.cs
* Move DataProtection to main

* Update Changelog.md

* bump version for Az.Dataprotection

* update version in AzPreview.psd1

Co-authored-by: azure-powershell-bot <[email protected]>
* enable Private link support

* both set to true

* Add testcase

* Add recording

Co-authored-by: Vishakha Narvekar <[email protected]>
BethanyZhou and others added 26 commits July 6, 2022 15:13
* Update Get-AzKeyVaultCertificate.md

* Update Get-AzKeyVaultCertificate.md
* [KeyVault] Remove the warning messages for MSGraph migration

* [Az.Resources] Remove the warning messages for MSGraph migration

* [Az.Sql] Remove the warning messages for MSGraph migration

* [Az.Aks] Remove the warning messages for MSGraph migration

* Update ChangeLog.md

* Update ChangeLog.md
* fix bug for mismatched parameter value type

* fix some bugs

* fix bugs

* Apply suggestions from code review

Co-authored-by: Beisi Zhou <[email protected]>

* adjust indent

Co-authored-by: Beisi Zhou <[email protected]>
* abandon codeRegex

* fix prompt regex

* fix MissingOutput error

* Fix bug for new-object typename
* add skip tag to files needed

* update skip files

* Update New-AzDataBoxJob.md

* Update New-AzDataBoxJob.md

* split code and output for Restore-AzApiManagement.md

* Update Add-AzEnvironment.md
* Added -Location parameter to Set- AzVMRunCommand

* Update src/Compute/Compute.Autorest/examples/Set-AzVMRunCommand.md

* Fixed typos

* Fixed typo

Co-authored-by: Beisi Zhou <[email protected]>
…18901)

* Updated Network changelog

Updated Network changelog

* Update ProviderConfiguration.cs
* recover severity

* fix a bug

* add some tips

* fix a bug

* fix some bugs for mismatchedType and change severity==1

* add tips

* add tips
Trusted launch requires the creation of new virtual machines. You can't enable trusted launch on existing virtual machines that were initially created without it.

More Info: https://docs.microsoft.com/en-us/azure/virtual-machines/trusted-launch
fixes #18204
…on (#18903)

* Update MoveFromGeneration2Master.ps1

* Update MoveFromGeneration2Master.ps1
…18908)

* Update MinimalVersion.csv

* Update Az.psd1

* Update Changelog.md

* Update MinimalVersion.csv
…release) (#18917)

* Update AzPreview.psd1 after each releasae (including OOB and preview release)

* refine codes
* Move DnsResolver to main

* Update Changelog.md

Co-authored-by: azure-powershell-bot <[email protected]>
…Version.csv (#18919)

* If only bump one module, only remove its minimal version from MinimalVersion.csv

* polish code

* update
* install storage account

* fix a bug

* fix unassigned_parameter; no silentErrorAction; split errors and warnings

* fix a bug

* fix position parameter

* try to fix invalid_cmdlet

* fix some isssues

* fix a bug

* skip -name <type>

* regress for -name <Type>

* fix issues

* Update .azure-pipelines/util/analyze-steps.yml

Co-authored-by: Yeming Liu <[email protected]>

Co-authored-by: Yeming Liu <[email protected]>
…cedThreatProtection cmdlets from 9.0.0 (#18929)

* Updating Sql .NET SDK to 3.1.0-preview.
Declare breaking changes for AdvancedDataSecurity and AdvancedThreatProtection cmdlets.

* Added ChangeLog
* Move DnsResolver to main

* Update Changelog.md

Co-authored-by: azure-powershell-bot <[email protected]>
* Update breakingchange-for-autogen-module.md

* Update breakingchange-for-autogen-module.md
* fix Capitalization Conventions

* fix severity

* Apply suggestions from code review

Co-authored-by: Yeming Liu <[email protected]>

Co-authored-by: Yeming Liu <[email protected]>
@BethanyZhou
Copy link
Contributor

BethanyZhou commented Jul 20, 2022

What's this PR for? Can we close it?

@BethanyZhou BethanyZhou added the needs-author-feedback More information is needed from author to address the issue. label Jul 20, 2022
@BethanyZhou
Copy link
Contributor

Close as it's same with #18953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-author-feedback More information is needed from author to address the issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.