Skip to content

Conversation

@isra-fel
Copy link
Member

@isra-fel isra-fel commented Jul 4, 2022

Description

Fix #18207

Az.props doesn't need to be synced because in CI it is copied from main branch. See

Copy-Item "$PSScriptRoot\..\src\*.props" $TmpFolder

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou
Copy link
Contributor

I added a prop file named Az.Post.props in previous release. I'm wondering whether it should be added into the sync list as well.

@isra-fel
Copy link
Member Author

isra-fel commented Jul 6, 2022

@BethanyZhou yes, if that file is necessary for building the module on main branch, it needs to be synced to generation branch.

@isra-fel isra-fel merged commit 018658f into main Jul 6, 2022
@isra-fel isra-fel deleted the isra-fel-patch-3 branch July 6, 2022 07:27
@BethanyZhou
Copy link
Contributor

Seems like Az.Post.props is same with Az.props. It Will be copied from main branch. No need to add it in sync list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Eng]: sync more files from main to generation branch

3 participants