-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Enable ARM to the Private Link connection Cmdlets #18358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Network/Network/PrivateLinkService/PrivateLinkServiceProvider/ProviderConfiguration.cs
Outdated
Show resolved
Hide resolved
BethanyZhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the cmdlet works even swagger didn't contain the API? @Vishakha-Git
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Yes they worked |
1 similar comment
Yes they worked |
Any suggestion @BethanyZhou not sure why the test are failing on Windows and MacOS. Also from other PRs enabling providerConfig for private links haven't checked-in any testcase. RegisterConfiguration; Should I remove the testcases in this PR? |
|
The failure in windows is thrown by Batch Tests and others are caused by timeout @VeryEarly , could you have a look? @Vishakha-Git ,our test framework does not support testing data-plane. if your feature is in data-plane, please mark it as Category.LiveOnly. If not, I think it's great to have a test. |
Got it Thanks. |
|
Are we waiting for a fix for the Batch Test that is timing out? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…rsion 2022-04-01-preview (#18476) * Fix Az.ContainerRegistry Xml Comments (#18388) * Fix Az.CosmosDB XML Comments (#18401) * Fix Az.CosmosDB XML Comments * Fix Az.CosmosDB XML Comments * Update PSClientEncryptionPolicy.cs Co-authored-by: Ziyue Zheng <[email protected]> * Fix Az.DataBoxEdge XML Comments (#18402) * Fix Az.Automation XML Comments (#18407) * Fix Az.Automation XML Comments * Fix Az.Automation XML Comments * Update SourceControlSyncJobStream.cs Co-authored-by: Ziyue Zheng <[email protected]> * Fix Az.DataLakeAnalytics XML Comments (#18403) * Fix Az.Compute XML Comments (#18408) * Fix Az.Compute XML Comments * Fix Az.Compute.Helpers XML Comments * Fix Az.DataLakeStore XML Comments (#18421) * Fix Az.DataLakeStore XML Comments * Fix Az.DataLakeStore XML Comments Co-authored-by: Ziyue Zheng <[email protected]> * Fix Az.DataMigration XML Comments (#18422) * Fix Az.EventHub XML Comments (#18429) * Fix Az.EventHub XML Comments * Update PSNetworkRuleSetAttributes.cs Co-authored-by: Ziyue Zheng <[email protected]> * Fix Az.HDInsight XML Comments (#18432) * Fix Az.IotHub XML Comments (#18433) * Fix Az.IotHub XML Comments * Fix Az.IotHub XML Comments Co-authored-by: Ziyue Zheng <[email protected]> * [CosmosDB] Fixes issue with Update-AzCosmosDBSqlContainer command on containers with Client Encryption Policy (#18480) * Support client encryption policy during container creation * Update SqlOperationsTests.ps1 * Update New-AzCosmosDBSqlContainer.md * Update PSClientEncryptionPolicy.cs * Update NewAzCosmosDBSqlContainer.cs * Update ChangeLog.md * Updated package. * Update CosmosDB.Test.csproj * Updated example, session records. * updated session records. * Fixes update container command on containers with client encryption policy. * Update ChangeLog.md * Update ChangeLog.md * Bug fix for the Restore-AzSqlDatabase cmdlet (#18475) * Pass Tags field in the Database model constructor * Update change log * Remove WebsitesController (#18469) * Remove WebsitesController * Update WebsitesTestRunner.cs * Update WebsitesTestRunner.cs * Fixed issue when mimicing long running operation for test in Playback mode. (#18490) * [Az.DataProtection] OOB for Az.DataProtection (#18477) * Move DataProtection to main * Update Changelog.md * bump version for Az.Dataprotection * update version in AzPreview.psd1 Co-authored-by: azure-powershell-bot <[email protected]> * Enable ARM to the Private Link connection Cmdlets (#18358) * enable Private link support * both set to true * Add testcase * Add recording Co-authored-by: Vishakha Narvekar <[email protected]> * Initial changes for network manager resources * add network manager models * added all network maneger files * update signature issues and project files containing network reference * remove version bump, will be generated * add all helps docs for network manager commands * Update Remove-AzNetworkManagerGroup.md * Update Remove-AzNetworkManagerGroup.md * Update Remove-AzNetworkManagerSecurityAdminConfiguration.md * Update Remove-AzNetworkManagerSecurityAdminRule.md * Update Remove-AzNetworkManagerSecurityAdminRuleCollection.md * fix help * reset help to retriggle validation * reset test * fix test Co-authored-by: v-yuzhichen <[email protected]> Co-authored-by: Ziyue Zheng <[email protected]> Co-authored-by: Santosh Kulkarni <[email protected]> Co-authored-by: Ishan Rajesh Madan <[email protected]> Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: Yabo Hu <[email protected]> Co-authored-by: azure-powershell-bot <[email protected]> Co-authored-by: Vishakha-Git <[email protected]> Co-authored-by: Vishakha Narvekar <[email protected]> Co-authored-by: Jared Gorthy <[email protected]> Co-authored-by: yanfa317 <[email protected]> Co-authored-by: Fan Yang (AZURE) <[email protected]>
Description
Enabling Microsoft.Authorization/resourceManagementPrivateLinks owned by the Azure Resource Manager team to the Private Link Common Cmdlets
Follow-up for Onboarding PR #15858
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added