Skip to content

Conversation

@MoChilia
Copy link
Member

@MoChilia MoChilia commented Jul 7, 2022

Description

In this Pr, we recover severity for errors, delete intermediate files: Missing.csv, DeletingSeparating.csv, Scale.csv, and outputs error records with severity>=2 when there are critical issues (records with severity<=1).

Fix Mismatched_Parameter_Type:

  1. Support using Convert Expression to assign variables
    $var = [Type] value
  2. Support analyzing members for variables in Assignment Statement
    $var = $left.member + $right

Test Pr: #18895

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@MoChilia MoChilia marked this pull request as ready for review July 8, 2022 00:49
@MoChilia MoChilia requested a review from isra-fel July 8, 2022 00:49
hasError = true;
errorText.AppendLine(record.FormatRecord());
}
else if (record.Severity > 1 && outputWarning)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not show informational issues but only show warnings, because the purpose of displaying these issues is to ask the PR author to fix them, but informational issues are not meant to be fixed.

Suggested change
else if (record.Severity > 1 && outputWarning)
else if (record.Severity == 2 && outputWarning)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@isra-fel isra-fel merged commit a098472 into main Jul 8, 2022
@MoChilia MoChilia deleted the shiying/ci-example-recoverSeverity branch July 11, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants