Skip to content

Conversation

@MoChilia
Copy link
Member

@MoChilia MoChilia commented Jul 12, 2022

Description

  1. Install Az-Cmdlets-latest.tar.gz locally to fix the problem that invalid_cmdlet occurs when the module didn't build in debug folder. Retry when invoke failed.
  2. Regress the phases for src\ModuleName\**\*.md from build: related-module to build: module in .ci-config.json
  3. Fix unassigned_parameter for assigning by and mark them with expression "<NoValue>"
  4. Split errors and warnings to show issues more clearly
  5. Redo-ImportModule when invalid_cmdlet occurred (try to fix the random false positive of invalid_cmdlet)
  6. Skip needDeleting in Storage module

Test Pr: #18923
Test for codegen/Compute: #18927

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@MoChilia MoChilia marked this pull request as ready for review July 13, 2022 06:19
@MoChilia MoChilia requested a review from isra-fel July 13, 2022 06:20
@isra-fel
Copy link
Member

Context: example of one module may include cmdlets from another module. This is tricky because that other module may not be built on CI, because normally only the modified module and those whose tests rely on the modified module are built. We cannot analyze the cmdlets of the modules that are not built.

The solution is to pre-install the latest Az modules. By doing so when a module is not built, we are still able to leverage the installed module to gather cmdelt information.

@isra-fel isra-fel merged commit cc27f7c into main Jul 13, 2022
@MoChilia MoChilia deleted the shiying/ci-example-fix branch July 14, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants