Skip to content

Conversation

@BethanyZhou
Copy link
Contributor

@BethanyZhou BethanyZhou commented Jun 9, 2022

Description

Added two parameter sets to support accepting rotation policy in a JSON file:

   Set-AzKeyVaultKeyRotationPolicy [-VaultName] <string> [-Name] <string> -PolicyPath <string> [-DefaultProfile
    <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]

    Set-AzKeyVaultKeyRotationPolicy [-InputObject] <PSKeyVaultKeyIdentityItem> -PolicyPath <string> [-DefaultProfile
    <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]

Two breaking changes are allowed by Damien and Dingmeng

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou BethanyZhou marked this pull request as ready for review June 9, 2022 10:48
@VeryEarly VeryEarly self-assigned this Jun 10, 2022
@VeryEarly VeryEarly merged commit c834195 into Azure:main Jun 10, 2022
@BethanyZhou BethanyZhou deleted the rotationpolicy branch June 10, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants