Skip to content

Sync to master #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 855 commits into from
May 13, 2020
Merged

Sync to master #3

merged 855 commits into from
May 13, 2020

Conversation

zztalker
Copy link
Owner

No description provided.

DonJayamanne and others added 30 commits April 1, 2020 14:07
* Include files
* Fix sonar issues
* Fix test
* Include bundle analyzer to see the size of ipywidgets bundle
* Oops
* Skip UI tests
* Route load failures to the UI

* Add message to output and fix unknown mime type

* Put back azureml

* Add news entry

* Update dependencies

* Add telemetry

* Fixup after merge. (Comm works now, so it stops executing)
* Split Azure ML Widget files
* Load dynamically
* Revert
* Remove bootstrap

* Remove bootstrap
* added npm packages and created the kernel launcher

* created .d.ts files and corrected some problems
on the kernel launcher

* got rid of all the errors

* deleted npm packages and *.d.ts

* kernel launcher rework

* run python process,
made the kernel launcher injectable,
create a types file

* finish kernel launcher

* add tests

* removed unused import

* finished tests, promisified portfinder

* added news file

* updated package-lock.json

* Added the kernel finder.
Removed extra dependencies from package-lock.json

* leave the launcher ready to support
other languages

* added logic to the kernel launcher in case
the notebook and selection interpreters are different

* returned tests to normal

* fixed tests

* Added zmq test
made all file searching async

* fix env variables for tests

* return launch.json to its original state

* address PR comments

* address PR comments

* address PR comments part 3

* added kernelfinder and kernelprocess to
serviceRegistry

* address PR comments part IV: A New Hope
- still using promisify on getPorts
- still not saving the cachedKernelSpecs on a file

* Address more PR comments

* work on the kernel finder tests

* finished the kernel finder tests

* fixed linting issues

* hygiene

* pr comments

* remove unnecesary import

* gulp fix

* restore launch.json

* move a readCache out of a loop

* removed unnecesary variable

* pr comments

* only read and write on the cache once

* remove ioc container from unit tests

* prevent using undefined env var
* Refactor remote debugger script API and tests

* Fix test issues

* linter fix
* Experiments should not block on telemetry.

* Fix tests

* Fix linter issue
* News file
* Define telemetry event
* add verb to telemetry prop
* Send telemetry where needed + fix existing tests
* Unit tests for checks on workspace activation
* Add test for environment variables provider
* Change mock defaultValue to 'defaultValue'
* Add unit tests for settings update
* Env file telemetry unit tests (+ stub trick)
* Lol remove lorem
* Resetting global state is needed
* Ok fine I ran the entire test suite, happy now
// Removed all the unit test debugging commits
* Update src/client/telemetry/index.ts
Co-Authored-By: Eric Snow <[email protected]>
* Encapsulate all EnvFileTelemetry logic
… - 6.1.3, server - 6.1.1) (#10959)

* update vscode-languageserver/client to latest version

* moved vscode-languageclient/server to latest released version (client - 6.1.3, server - 6.1.1)
…ibuting guide (#10917)

* Replacing ptvsd with debugpy in remote attach config prompt

* Add contributing.md back

* Update package.nls.zh-tw.json to be generic to any DAP

Co-Authored-By: Karthik Nadig <[email protected]>

* Update package.nls.zh-tw.json to be generic to any DAP

Co-Authored-By: Karthik Nadig <[email protected]>

* Make configuration prompt wording for  remote attach to be generic

Co-Authored-By: Karthik Nadig <[email protected]>

* Make configuration prompt wording for  remote attach to be generic

Co-Authored-By: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>
* Update debugger to latest

* Update debugpy to latest (#10935)
* Disable loading scripts from unpkg for widgets
* Oops
* Updated
* review fixes
For #10681

The key change here is the separation (under src/client/common/process) of Python environment helpers from running Python processes. This helps simplify later changes needed for #10681, as well as other code health benefits.

A small related change: adding PythonExecutionInfo.python (which helps simplify composition of exec args in some situations).

There should be zero change in behavior.
* Update experiments json to include ipywidgets

* Update experiments.json
For #10681

This makes it much easier to make changes that are specific to internal scripts generally, like send them through a separate script to run them isolated.

There should be zero change in behavior.
* Add back message hooks

* Redesign with output working

* Fix hooks to bind correctly. Dont send kernel info more than once

* Fix k3d and change rendering algorithm

* Turn off full logging

* Clean up logging and add more for ipywidgets

* Truly turn off logging of redux output

* Fix hook to wait for last message received before being removed

* Update test data

* Add news entry

* Review feedback. Put back restart

* Fix restart to work. Was missing postOffice removeHandler

* fix sonar problems

* Update description

* Only run bundle analyzer on local machines

* Fix check dependencies

* Actually use the variable

* Fix aml mini widget to not output an error

* Review feedback

* Fix problem with ipywidgets being disabled during functional tests

* Review feedback and fixing functional tests

* Fix build errors

* Use experiment instead of package.json setting

* REmove unused log files
…#10687)

* replace default Progress with custom icon when downloading
* extract formatProgressMessageWithState method for readability
* add news entry for #10495
* move icon display logic to `downloadFileWithStatusBarProgress`
* move RequestProgressState to fileDownloader and move formatProgressMessageWithState at module level
* fix try block to also catch download initialization errors
* add withProgressCustomIcon method
* use withProgressCustomIcon in fileDownloader.ts
* fix withProgressCustomIcon
* adapt fileDownloader unit tests
* add doc for icon param
* drop param `options` in withProgressCustomIcon
* update test_plan
Co-authored-by: Erwan de Lépinau <[email protected]>
* Preserve code in cells during execution and edits
* Oops
* Attempt to fix interpreter mismatch in another branch

* Add news entries

* Use clone deep and assume it's a full interpreter

* Actually fix the click on markdown
rchiodo and others added 29 commits May 7, 2020 18:16
* Fix scrolling

* Review feedback - fix scrolling on expand/collapse
…ter (#11654)

* add onSuggestion option
* Swap onActivation with onSuggestion
* Update unit tests
* Remove registration of IPipenvService
* Move didTriggerInterpreterSuggestions logic inside pipenv locator
* Fix existing unit tests
* Add new unit tests
* Replace typemoq any param with object
* Shorten the tests
* Fix warning
* Duplicate teardown
* Remove all other version of debugpy

* Add news

* fix linting

* Fix debugpy install for py 2.7 tests
* Potential idea

* Make debug variables work after restart and get shape/count

* Add restart testing

* Force refresh during test

* Make stepping with variables work

* All tests working
* Nicer experience for installing DS dependencies

* Fix test

* Don't test installing nbconvert

* Handle no pip

* Whoops

* Fix unit tests.
* Potential idea

* Make debug variables work after restart and get shape/count

* Add restart testing

* Force refresh during test

* Make stepping with variables work

* All tests working

* Already working, just add a bunch of tests

* Add more tests for data frame info fetching

* Add news entry
* Functional test for run by line

* Fix linter
For #10496
This prevents unnecessary updates the UI and reduces chatter
Basically less chatty messages and fewer UI updates
* Fix run by line to scroll to the current location when stepping
Fix install message to reference run by line

* Add in icon changes as well

* Fix merge error too
* Initial idea

* Add some comments

* Add to test matrix

* Add news entry

* Code review feedback and making sure not to take too long to return a hover

* Update hover during debugging to include type
* Fix for not allowing other schemes.

* Fix scrolling for interactive vs native editor

* Update comment.
We now use NOTICED
* Fix typo lanaguage -> language

* Create 11775.md
Even with a good understanding of both VSCode-Python and Jedi,
this is easy to overlook.
@zztalker zztalker merged commit e63fb51 into zztalker:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.