Merge pull request #3 from microsoft/master

Sync to upstream

Author: zztalker

.devcontainer/Dockerfile

@@ -5,30 +5,49 @@
 
 FROM node:8
 
-# Configure apt
+# Avoid warnings by switching to noninteractive
 ENV DEBIAN_FRONTEND=noninteractive
-RUN apt-get update \
-    && apt-get -y install --no-install-recommends apt-utils 2>&1
 
-# Verify git and needed tools are installed
-RUN apt-get install -y git procps
+# The node image comes with a base non-root 'node' user which this Dockerfile
+# gives sudo access. However, for Linux, this user's GID/UID must match your local
+# user UID/GID to avoid permission issues with bind mounts. Update USER_UID / USER_GID 
+# if yours is not 1000. See https://aka.ms/vscode-remote/containers/non-root-user.
+ARG USER_UID=1000
+ARG USER_GID=$USER_UID
 
-# Remove outdated yarn from /opt and install via package 
-# so it can be easily updated via apt-get upgrade yarn
-RUN rm -rf /opt/yarn-* \
+# Configure apt and install packages
+RUN apt-get update \
+    && apt-get -y install --no-install-recommends apt-utils dialog 2>&1 \
+    #
+    # Verify git and needed tools are installed
+    && apt-get -y install git iproute2 procps \    
+    #
+    # Remove outdated yarn from /opt and install via package 
+    # so it can be easily updated via apt-get upgrade yarn
+    && rm -rf /opt/yarn-* \
     && rm -f /usr/local/bin/yarn \
     && rm -f /usr/local/bin/yarnpkg \
     && apt-get install -y curl apt-transport-https lsb-release \
     && curl -sS https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/pubkey.gpg | apt-key add - 2>/dev/null \
     && echo "deb https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/ stable main" | tee /etc/apt/sources.list.d/yarn.list \
     && apt-get update \
-    && apt-get -y install --no-install-recommends yarn
-
-# Install tslint and typescript
-RUN npm install -g tslint typescript
-
-# Clean up
-RUN apt-get autoremove -y \
+    && apt-get -y install --no-install-recommends yarn \
+    #
+    # Install tslint and typescript globally
+    && npm install -g tslint typescript \
+    #
+    # [Optional] Update a non-root user to match UID/GID - see https://aka.ms/vscode-remote/containers/non-root-user.
+    && if [ "$USER_GID" != "1000" ]; then groupmod node --gid $USER_GID; fi \
+    && if [ "$USER_UID" != "1000" ]; then usermod --uid $USER_UID node; fi \
+    # [Optional] Add add sudo support for non-root user
+    && apt-get install -y sudo \
+    && echo node ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/node \
+    && chmod 0440 /etc/sudoers.d/node \
+    #
+    # Clean up
+    && apt-get autoremove -y \
     && apt-get clean -y \
     && rm -rf /var/lib/apt/lists/*
-ENV DEBIAN_FRONTEND=dialog
+
+# Switch back to dialog for any ad-hoc use of apt-get
+ENV DEBIAN_FRONTEND=

.devcontainer/devcontainer.json

@@ -1,8 +1,26 @@
-// See https://aka.ms/vscode-remote/devcontainer.json for format details.
+// For format details, see https://aka.ms/vscode-remote/devcontainer.json or the definition README at
+// https://github.com/microsoft/vscode-dev-containers/tree/master/containers/typescript-node-8
 {
-	"name": "Node.js 8 & TypeScript",
-	"dockerFile": "Dockerfile",
-	"extensions": [
-		"ms-vscode.vscode-typescript-tslint-plugin"
-	]
-}
+    "name": "Node.js 8 & TypeScript",
+    "dockerFile": "Dockerfile",
+
+    // Use 'settings' to set *default* container specific settings.json values on container create.
+    // You can edit these settings after create using File > Preferences > Settings > Remote.
+    "settings": {
+        "terminal.integrated.shell.linux": "/bin/bash"
+    },
+
+    // Uncomment the next line if you want to publish any ports.
+    // "appPort": [],
+
+    // Uncomment the next line to run commands after the container is created.
+    // "postCreateCommand": "yarn install",
+
+    // Uncomment the next line to use a non-root user. On Linux, this will prevent
+    // new files getting created as root, but you may need to update the USER_UID
+    // and USER_GID in .devcontainer/Dockerfile to match your user if not 1000.
+    // "runArgs": [ "-u", "node" ],
+
+    // Add the IDs of extensions you want installed when the container is created in the array below.
+    "extensions": ["ms-vscode.vscode-typescript-tslint-plugin"]
+}

.env

@@ -9,7 +9,9 @@
 		"no-cond-assign": 0,
 		"no-unused-vars": 1,
 		"no-extra-semi": "warn",
-		"semi": "warn"
+        "semi": "warn",
+        "prettier/prettier": "error"
 	},
-	"extends": "eslint:recommended"
+    "extends": ["eslint:recommended", "prettier"],
+    "plugins": ["prettier"]
 }

.eslintrc

@@ -1,2 +1,3 @@
 package.json text eol=lf
 package-lock.json text eol=lf
+requirements.txt text eol=lf

.gitattributes

@@ -3,6 +3,7 @@ name: Bug report for Notebook Editor, Interactive Window, Python Editor cells
 about: Create a report to help us improve
 labels: type-bug, data science
 ---
+
 # Bug: Notebook Editor, Interactive Window, Editor cells
 
 <!-----------------------------------------------------------------------------------------------
@@ -13,6 +14,7 @@ bug template instead of this one. ***Thank you!***
 ------------------------------------------------------------------------------------------------->
 
 ## Steps to cause the bug to occur
+
 1.
 
 ## Actual behavior
@@ -25,22 +27,23 @@ https://github.com/phw/peek or https://www.screentogif.com/ to create one.
 ------------------------------------------------------------------------------------------------->
 
 ### Your Jupyter and/or Python environment
-*Please provide as much info as you readily know*
-- **Jupyter server running:**                       Local | Remote | N/A
-- **Extension version:**                               20YY.MM.#####-xxx
-- **VS Code version:**                                #.##
-- **Setting python.jediEnabled:**               true | false
-- **Python and/or Anaconda version:**     #.#.#
-- **OS:**                                                     Windows | Mac | Linux (distro):
-- **Virtual environment:**                          conda | venv | virtualenv | N/A | ...
+
+_Please provide as much info as you readily know_
+
+-   **Jupyter server running:** Local | Remote | N/A
+-   **Extension version:** 20YY.MM.#####-xxx
+-   **VS Code version:** #.##
+-   **Setting python.jediEnabled:** true | false
+-   **Python and/or Anaconda version:** #.#.#
+-   **OS:** Windows | Mac | Linux (distro):
+-   **Virtual environment:** conda | venv | virtualenv | N/A | ...
 
 ## Developer Tools Console Output
+
 <!-----------------------------------------------------------------------------------------------
 Copy/paste the output in the "Console" tab in the "Developer Tools" panel (Help >
 Toggle Developer Tools). For better details, run the "Enable source map support for
 extension debugging" command in VS Code at least once beforehand.
 ------------------------------------------------------------------------------------------------->
-Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer
-
-
 
+Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

.github/ISSUE_TEMPLATE/1_ds_bug_report.md

@@ -8,13 +8,15 @@ labels: classify, type-bug
 
 ## Environment data
 
-- VS Code version: XXX
-- Extension version (available under the Extensions sidebar): XXX
-- OS and version: XXX
-- Python version (& distribution if applicable, e.g. Anaconda): XXX
-- Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
-- Relevant/affected Python packages and their versions: XXX
-- Jedi or Language Server? (i.e. what is `"python.jediEnabled"` set to; more info #3977): XXX
+-   VS Code version: XXX
+-   Extension version (available under the Extensions sidebar): XXX
+-   OS and version: XXX
+-   Python version (& distribution if applicable, e.g. Anaconda): XXX
+-   Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
+-   Relevant/affected Python packages and their versions: XXX
+-   Relevant/affected Python-related VS Code extensions and their versions: XXX
+-   Jedi or Language Server? (i.e. what is `"python.jediEnabled"` set to; more info #3977): XXX
+-   Value of the `python.languageServer` setting: XXX
 
 ## Expected behaviour
 
@@ -25,6 +27,7 @@ XXX
 XXX
 
 ## Steps to reproduce:
+
 [**NOTE**: Self-contained, minimal reproducing code samples are **extremely** helpful and will expedite addressing your issue]
 
 1. XXX
@@ -34,14 +37,34 @@ Note: If you think a GIF of what is happening would be helpful, consider tools l
 -->
 
 ## Logs
-Output for `Python` in the `Output` panel (`View`→`Output`, change the drop-down the upper-right of the `Output` panel to `Python`)
+
+<details>
+
+<summary>Output for <code>Python</code> in the <code>Output</code> panel (<code>View</code>→<code>Output</code>, change the drop-down the upper-right of the <code>Output</code> panel to <code>Python</code>)
+</summary>
+
+<p>
 
 ```
 XXX
 ```
 
-Output from `Console` under the `Developer Tools` panel (toggle Developer Tools on under `Help`; turn on source maps to make any tracebacks be useful by running `Enable source map support for extension debugging`)
+</p>
+</details>
+
+<br />
+
+<details>
+
+<summary>
+Output from <code>Console</code> under the <code>Developer Tools</code> panel (toggle Developer Tools on under <code>Help</code>; turn on source maps to make any tracebacks be useful by running <code>Enable source map support for extension debugging</code>)
+</summary>
+
+<p>
 
 ```
-XXX
+XXXX
 ```
+
+</p>
+</details>

.github/ISSUE_TEMPLATE/2_bug_report.md

@@ -3,6 +3,7 @@ name: Feature request for Notebook Editor, Interactive Window, Editor cells
 about: Suggest an idea for this project
 labels: type-enhancement, data science
 ---
+
 # Feature: Notebook Editor, Interactive Window, Python Editor cells
 
 <!-----------------------------------------------------------------------------------------------
@@ -14,7 +15,4 @@ request template instead of this one. ***Thank you!***
 
 ## Description
 
-
 Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer
-
-

.github/ISSUE_TEMPLATE/3_ds_feature_request.md

@@ -1,4 +1,4 @@
-blank_issues_enabled: true
+blank_issues_enabled: false
 contact_links:
   - name: Stack Overflow
     url: https://stackoverflow.com/questions/tagged/visual-studio-code+python

.github/ISSUE_TEMPLATE/config.yml

@@ -4,13 +4,14 @@ For #
   If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.:
     - [x] ~Has unit tests & system/integration tests~
 -->
-- [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
-- [ ] Title summarizes what is changing
-- [ ] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)
-- [ ] Appropriate comments and documentation strings in the code
-- [ ] Has sufficient logging.
-- [ ] Has telemetry for enhancements.
-- [ ] Unit tests & system/integration tests are added/updated
-- [ ] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate
-- [ ] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)
-- [ ] The wiki is updated with any design decisions/details.
+
+-   [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
+-   [ ] Title summarizes what is changing.
+-   [ ] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!).
+-   [ ] Appropriate comments and documentation strings in the code.
+-   [ ] Has sufficient logging.
+-   [ ] Has telemetry for enhancements.
+-   [ ] Unit tests & system/integration tests are added/updated.
+-   [ ] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate.
+-   [ ] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed).
+-   [ ] The wiki is updated with any design decisions/details.