Skip to content

Remove tpn #11765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020
Merged

Remove tpn #11765

merged 1 commit into from
May 12, 2020

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented May 12, 2020

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

We now use NOTICED as maintained by the OSPO internally
@brettcannon brettcannon requested a review from karthiknadig May 12, 2020 19:21
@brettcannon brettcannon added the no-changelog No news entry required label May 12, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@codecov-io
Copy link

Codecov Report

Merging #11765 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11765      +/-   ##
==========================================
- Coverage   60.64%   60.63%   -0.02%     
==========================================
  Files         628      628              
  Lines       33953    33954       +1     
  Branches     4782     4781       -1     
==========================================
- Hits        20592    20588       -4     
- Misses      12363    12367       +4     
- Partials      998      999       +1     
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/datascience/types.ts 100.00% <0.00%> (ø)
...datascience/interactive-common/notebookProvider.ts 48.14% <0.00%> (ø)
...active-common/intellisense/intellisenseProvider.ts 37.84% <0.00%> (+0.19%) ⬆️
...ience/interactive-common/notebookServerProvider.ts 56.52% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adff6ba...a34ada2. Read the comment docs.

@brettcannon brettcannon merged commit 49e2352 into microsoft:master May 12, 2020
@brettcannon brettcannon deleted the remove-tpn branch May 12, 2020 23:37
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants