Show an error when we cannot load a particular widget #10907
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10907 +/- ##
==========================================
- Coverage 60.67% 60.65% -0.02%
==========================================
Files 580 580
Lines 31530 31531 +1
Branches 4480 4480
==========================================
- Hits 19131 19126 -5
- Misses 11429 11433 +4
- Partials 970 972 +2
Continue to review full report at Codecov.
|
| @@ -201,4 +201,47 @@ export namespace CommonEffects { | |||
| cellVMs: newVMs | |||
| }; | |||
| } | |||
|
|
|||
| export function handleLoadIPyWidgetClassFailure( | |||
There was a problem hiding this comment.
Should we add some telemetry for this.
Would be good to track how often this happens and whether it is due to lack of network connection.
| @@ -579,12 +579,6 @@ export class CellOutput extends React.Component<ICellOutputProps> { | |||
| // Silently skip rendering of these mime types, render an empty div so the user sees the cell was executed. | |||
| buffer.push(<div key={index}></div>); | |||
| } else { | |||
| if (transformed.output.data) { | |||
There was a problem hiding this comment.
Sorry, what's this removal for?
There was a problem hiding this comment.
There's a bug here. This used to go through this case when the mimetype was empty. But it goes through this case now when we don't have a match (mimetype empty does nothing). The logic here is unnecessary if we have an actual mimetype.
This repros with the azureml widget as it puts up a 'loading' widget that we don't support.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@rchiodo |
For #9523
When loading 3rd party controls, their source may not be on unpkg.com. When this happens show an error to the user. If they're not connected to the internet, tell them this is likely why.
I tested this by removing our require define for azureml (as it's not on unpkg.com)