Skip to content

Functional test for run by line #11746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2020
Merged

Functional test for run by line #11746

merged 2 commits into from
May 11, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented May 11, 2020

For #11660

Add a new test that ensures run by line continues to work.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #11746 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11746      +/-   ##
==========================================
- Coverage   60.72%   60.66%   -0.06%     
==========================================
  Files         629      628       -1     
  Lines       34007    33908      -99     
  Branches     4795     4774      -21     
==========================================
- Hits        20650    20571      -79     
+ Misses      12364    12339      -25     
- Partials      993      998       +5     
Impacted Files Coverage Δ
...ience/interactive-common/interactiveWindowTypes.ts 100.00% <100.00%> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/common/utils/misc.ts 63.63% <0.00%> (-10.73%) ⬇️
src/client/logging/transports.ts 77.77% <0.00%> (-3.48%) ⬇️
src/client/common/utils/decorators.ts 78.02% <0.00%> (-2.38%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/common/logger.ts 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063c33d...bdbbf70. Read the comment docs.

@rchiodo rchiodo merged commit 5ae9f96 into master May 11, 2020
@rchiodo rchiodo deleted the rchiodo/runbyline_functional branch May 11, 2020 22:21
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants