Use a proxy web socket with a real kernel in UI layer for IPyWidgets #10887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10887 +/- ##
==========================================
- Coverage 60.67% 60.63% -0.05%
==========================================
Files 580 580
Lines 31528 31555 +27
Branches 4479 4490 +11
==========================================
+ Hits 19131 19132 +1
- Misses 11427 11445 +18
- Partials 970 978 +8
Continue to review full report at Codecov.
|
DonJayamanne
commented
Apr 1, 2020
DonJayamanne
commented
Apr 1, 2020
DonJayamanne
commented
Apr 1, 2020
DonJayamanne
commented
Apr 1, 2020
| @@ -4,6 +4,8 @@ | |||
| import * as WebSocketWS from 'ws'; | |||
| import { traceInfo } from '../../common/logger'; | |||
|
|
|||
| export const JupyterWebSockets = new Map<string, WebSocketWS>(); | |||
There was a problem hiding this comment.
This is easier than a static property and works.
We couldnt use a static property due to restarts.
This works better as it is strongly typed.
DonJayamanne
commented
Apr 1, 2020
DonJayamanne
changed the title
IanMatthewHuff
approved these changes
Apr 1, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10606