Skip to content

Hide generic named default kernels from the kernel switcher #11763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IanMatthewHuff
Copy link
Member

For #11552

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #11763 into master will decrease coverage by 0.08%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11763      +/-   ##
==========================================
- Coverage   60.71%   60.63%   -0.09%     
==========================================
  Files         629      628       -1     
  Lines       33999    33948      -51     
  Branches     4793     4781      -12     
==========================================
- Hits        20643    20583      -60     
- Misses      12364    12366       +2     
- Partials      992      999       +7     
Impacted Files Coverage Δ
...lient/datascience/jupyter/kernels/kernelService.ts 52.87% <50.00%> (+0.52%) ⬆️
...nt/datascience/jupyter/kernels/kernelSelections.ts 89.21% <62.50%> (-1.32%) ⬇️
src/client/datascience/jupyter/kernels/helpers.ts 91.66% <100.00%> (+4.16%) ⬆️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/common/utils/misc.ts 63.63% <0.00%> (-10.73%) ⬇️
src/client/common/installer/productInstaller.ts 86.16% <0.00%> (-6.67%) ⬇️
src/client/logging/transports.ts 77.77% <0.00%> (-3.48%) ⬇️
src/client/common/utils/decorators.ts 78.02% <0.00%> (-2.38%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aae900...d92dfa7. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit adff6ba into microsoft:master May 12, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/hideDefaultKernels branch May 12, 2020 17:23
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants