-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Release/v1.7.0 #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release/v1.7.0 #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add support for Python 3 (#428) * refactor: Updated imports to by Py3 compliant * refactor: Move class variable creation to constructor in globals.py Without moving this to the __init__, the globals.py file will not run in Py3 because it can't reference the constants. * refactor: Update update_policy.py to be Py3 compliant In Py3, the function .iteritems() on a dict was removed and replaced with .items(). * refactor: Update deployment_preference_collection.py to be Py3 compliant In Py3, .itervalues() and .iteritems() was replaced with .values() and .items(), respectfully. * refactor: Update swagger.py to be Py3 compliant In Py3, the .keys() method on a dictionary returns a dict_keys object that is a view into the dictionary. In Py2, it returns a list. To support Py3, we need to convert the .keys() to a list. * refactor: Update intrinsics.py to be Py3 compliant In Py3, the .keys() method on a dictionary returns a dict_keys object that is a view into the dictionary. In Py2, it returns a list. To support Py3, we need to convert the .keys() to a list. * Staging translator.py changes Updated .iteritems() to items() * refactor: More updating to be Py3 compliant * refactor: Make hashing constisent between py2 and py3 * refactor: Make exceptions sortable to allow error case tests to pass in Py3 * fix: add support for Python 3 (#445) * refactor: Updated imports to by Py3 compliant * refactor: Move class variable creation to constructor in globals.py Without moving this to the __init__, the globals.py file will not run in Py3 because it can't reference the constants. * refactor: Update update_policy.py to be Py3 compliant In Py3, the function .iteritems() on a dict was removed and replaced with .items(). * refactor: Update deployment_preference_collection.py to be Py3 compliant In Py3, .itervalues() and .iteritems() was replaced with .values() and .items(), respectfully. * refactor: Update swagger.py to be Py3 compliant In Py3, the .keys() method on a dictionary returns a dict_keys object that is a view into the dictionary. In Py2, it returns a list. To support Py3, we need to convert the .keys() to a list. * refactor: Update intrinsics.py to be Py3 compliant In Py3, the .keys() method on a dictionary returns a dict_keys object that is a view into the dictionary. In Py2, it returns a list. To support Py3, we need to convert the .keys() to a list. * Staging translator.py changes Updated .iteritems() to items() * refactor: More updating to be Py3 compliant * refactor: Make hashing constisent between py2 and py3 * refactor: Make exceptions sortable to allow error case tests to pass in Py3 * feat: Run tox from Travis-CI * feat: Update tox to run in Py2 and Py3 * refactor: Force sorting behavior to be Py2 compatible and update Deployment logicalid hash * fix: Update tox to run tests against Py27 and Py36 * Update Travis config to run Py2 and Py3 tests in parallel * Setting region env var in tox file for Travis to pick up * Set AWS region in travis file * Pass AWS_* env vars to tox * Fixing ordering of resource types in Globals error message * Py2/3 compatible implementation of string encoding for logicalId generator Also added lots of comments explaining why/how the deep sorting of lists work in unit tests * Removing redundant usage of bytes
Just a few minor rewords, plus a link to the sam-local-cli usage guide in the appropriate place.
A couple of minor grammatical corrections I noticed while reading the page.
* Both index.js and package.json were accidentally copied into this folder
DependsOn values can be either scalar strings or lists of strings. This change fixes handling when an S3 bucket in an input template has a scalar string value for DependsOn.
Currently CodeUri on Globals is not yet supported by CloudFormation package.
…504) * Update Maps section in globals to improve grammar and readability * Update Lists section in globals to improve grammar and readability * Remove outdated reference to supported resources section in globals * Wrap JSON attributes in double quotes
The app that's published to the Serverless Application Repository has replaced the custom policy with a policy template. The current published version also has a bug in it where it is not Ref'ing the parameter. This commit updates the template to match what's in the Serverless Application Repository and also fixes the Ref bug.
* docs: remove redundant/unused schema files in docs/ * point to policy_templates.json in samtranslator/ * remove unused policy templates schema in docs/ * docs: remove redundant/unused schema files in docs/ * point to policy_templates.json in samtranslator/ * remove unused policy templates schema in docs/
Adding the AWSSecretsManagerGetSecretValuePolicy policy to grant secretsmanager:GetSecretValue permissions to a single secret ARN.
* chore(cli): improve CLI error message for InvalidDocumentException * feat(plugins): added DefaultDefinitionBody plugin This makes DefinitionBody and DefinitionUri optional, and if not provided then the API will use the Swagger generated by SAM. This makes it easy for users who rely on Implicit API to use the existing Cors feature and upcoming Authorizers feature by defining an explicit API resource without needing to redefine their entire Swagger
…te (#548) `PutJobFailureResult` & `PutJobSuccessResult` do not support resource-level permissions and require you to choose All resources. https://docs.aws.amazon.com/codepipeline/latest/userguide/permissions-reference.html #389 closes #389
The schema is currently lacking and therefore is just noise. We may add this back in the future or remove it entirely.
* feat: Adds hello world VPC with comments and links to the docs * feat: Adds README including AWS CLI commands and links to Lambda VPC/NAT Gateway
* use policy templates and parameters * upgrade example apps from Node.js 4.3 to 8.10 * remove Metadata from templates
Change licenses for greengrass-hello-world-nodejs, greengrass-hello-world from Greengrass Core Software License Agreement to Apache 2.0 license.
* Added RekognitionDetectOnlyPolicy to SAM - To fix issue #245 and allow Detect* Rekognition permissions to be used without a collection ID. - I'm not too familiar with this code base, so I based my changes on where RekognitionNoDataAccessPolicy appeared. - So in the docs json, the samtranslator json and in the tests and examples - If this passes all of Travis's tests, I'll come back and fix the examples. * Fixed missing parameters. * Fixed failing tests correctly. * Fixed it with local testing this time.
This reverts commit 196a593.
chore: include enum34 fix and surface inline code docs in v1.7.0 release
brettstack
approved these changes
Sep 25, 2018
jlhood
approved these changes
Sep 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do it! 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAM v1.7.0 Release
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.