bug: simple-mobile-backend example app #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app that's published to the Serverless Application Repository has replaced the custom policy with a policy template. The current published version also has a bug in it where it is not Ref'ing the parameter. This commit updates the template to match what's in the Serverless Application Repository and also fixes the Ref bug.
keetonian
approved these changes
Aug 2, 2018
brettstack
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The simple-mobile-backend app version 1.0.0 published to the app repo didn't match this template (which is supposed to be the source code for that published app), and also had a bug in it where the template parameter was not being Ref'ed properly when it was used as a policy template parameter. This commit updates the template to match what's in the Serverless Application Repository and also fixes the Ref bug.
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.